Repository navigation
mctp-netlink: Return -errno from mctp_nl_send() on send failure - #184
Merged
Merged
Conversation
mctp_nl_send() has two error paths. When the kernel rejects the request, handle_nlmsg_ack() returns a negative errno. When sendto() itself fails, mctp_nl_send() returns sendto()'s -1 and leaves the reason in errno. Callers expect a negative errno. For example, mctpd prints strerror(-rc) when mctp_nl_route_add() or mctp_nl_route_del() fails, so a failed sendto() is logged as "Operation not permitted" (EPERM) whatever the real error was. Return -errno from the sendto() path too, so both paths report errors the same way. Signed-off-by: Kenny PH Hsieh <Kenny_Hsieh@jabil.com>
Member
|
Looks reasonable, but is there some issue that this is causing? |
Contributor
Author
No observed failure in mctpd, it's a consistency fix. |
Member
|
Merged, thanks! Out of curiosity, can you share details of this downstream daemon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mctp_nl_send() has two error paths. When the kernel rejects the request, handle_nlmsg_ack() returns a negative errno. When sendto() itself fails, mctp_nl_send() returns sendto()'s -1 and leaves the reason in errno.
Callers expect a negative errno. For example, mctpd prints strerror(-rc) when mctp_nl_route_add() or mctp_nl_route_del() fails, so a failed sendto() is logged as "Operation not permitted" (EPERM) whatever the real error was.
Return -errno from the sendto() path too, so both paths report errors the same way.