[Snyk] Security upgrade react-scripts from 2.1.8 to 5.0.0 - #171
[Snyk] Security upgrade react-scripts from 2.1.8 to 5.0.0#171CloudPower97 wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06b6c25342
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "react-router-dom": "^4.3.1", | ||
| "react-router-hash-link": "^1.2.1", | ||
| "react-scripts": "2.1.8", | ||
| "react-scripts": "5.0.0", |
There was a problem hiding this comment.
Align Node engine with react-scripts 5 requirements
The repo pins Node 10.x in the root package.json engines (lines 7–9), while react-scripts 5 no longer supports Node 10. If builds honor the engines field (e.g., Heroku via heroku-postbuild), installing or running yarn build for the client will fail after this upgrade. Consider bumping the engines field to a supported Node version or keeping react-scripts on a version compatible with Node 10 to avoid breaking CI/deploys that follow the engine pin.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
client/package.jsonclient/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.