Fix deadlock when ddl gets triggered during autovacuum - #126
Open
harshil-goel wants to merge 1 commit into
Open
Conversation
harshil-goel
force-pushed
the
harshil/ddl-autovacuum-bug
branch
from
September 4, 2026 17:41
d92f3ae to
a621e8d
Compare
harshil-goel
force-pushed
the
harshil/ddl-autovacuum-bug
branch
from
September 4, 2026 18:05
a621e8d to
75e0841
Compare
serprex
reviewed
Sep 4, 2026
Comment on lines
+293
to
+296
| let lsn = match bridge.replay_lsn().await? { | ||
| 0 => None, | ||
| lsn => Some(lsn), | ||
| }; |
Member
There was a problem hiding this comment.
serprex
reviewed
Sep 4, 2026
Comment on lines
+467
to
+474
| Datum key; | ||
| bool isnull; | ||
| Oid keyoid; | ||
|
|
||
| key = heap_getattr(tup, plan->keyattno, desc, &isnull); | ||
| if (isnull) | ||
| continue; | ||
| keyoid = DatumGetObjectId(key); |
Member
There was a problem hiding this comment.
let's get the C style of mixing declaration & assignment
serprex
reviewed
Sep 4, 2026
Comment on lines
+430
to
+433
| if (x < y) | ||
| return -1; | ||
| return (x > y) ? 1 : 0; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (x < y) | |
| return -1; | |
| return (x > y) ? 1 : 0; | |
| } | |
| return (x > y) - (x < y); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.