fix: make ClickHouseDataReader.IsClosed reflect disposal - #588
Open
fallintoplace wants to merge 1 commit into
Open
fix: make ClickHouseDataReader.IsClosed reflect disposal#588fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
requested review from
alex-clickhouse and
mzitnik
as code owners
August 25, 2026 07:50
fallintoplace
force-pushed
the
fix/reader-isclosed
branch
from
August 25, 2026 07:51
6a3e813 to
24befaa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ADO.NET reader lifecycle reporting by making ClickHouseDataReader.IsClosed accurately reflect disposal/closure, aligning behavior with expected DbDataReader semantics and preventing misleading state checks by consumers.
Changes:
- Track closed state via a new
isClosedfield and set it duringDispose(bool). - Update
IsClosedto return the tracked closed state. - Add a regression test asserting
IsClosedbecomestrueafter callingClose(), plus a changelog fragment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ClickHouse.Driver/ADO/Readers/ClickHouseDataReader.cs | Adds isClosed tracking and returns it from IsClosed, set during disposal so Close() (which calls Dispose()) is reflected. |
| ClickHouse.Driver.Tests/ADO/DataReaderTests.cs | Adds regression coverage to ensure IsClosed flips to true after Close(). |
| changelog.d/fix-reader-isclosed.fixes.md | Documents the user-visible bug fix in a changelog fragment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouseDataReader.IsClosedalways returnedfalse, even afterClose()orDispose().Dispose(bool).Close().Checklist