fix: accept the status message returned when attaching a domain - #10
Merged
Merged
Conversation
The vhost PUT endpoint answers with a status message ({"id", "message",
"type"}), not the vhost, so create_domain() raised InvalidResponseError on
every real call. The message is now accepted and the returned Domain
carries the requested name; a message of type "error" raises
InvalidResponseError instead of being reported as a success.
Reported in #9.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_domain()(added in 0.2.1) failed on every real call: thePUT /v2/organisations/{ownerId}/applications/{appId}/vhosts/{vhost}endpoint answers with a status message ({"id", "message", "type"}), not the vhost, and the method parsed it as aDomain, raisingInvalidResponseErroreven though the domain was attached. The tests mocked a{"fqdn": …}body, which hid it.Reported with a proposed fix in #9.
Changes
Domainbuilt from the requested name.fqdn: unchanged, parsed as before.Domainbuilt from the requested name."type": "error": raisesInvalidResponseErrorwith the message, instead of being reported as a success.InvalidResponseError, consistent with strict parsing since 0.2.0.Unreleased) and three tests.Test plan
uv run ruff check .uv run mypyuv run pytest🤖 Generated with Claude Code