Add Fedora RPM packaging and fix system theme sync - #174
Open
subhangadirli wants to merge 5 commits into
Open
Conversation
Plain GTK4 (without libadwaita) does not follow the desktop's dark-mode preference on its own. Read org.freedesktop.appearance color-scheme from the XDG Desktop Portal at startup and apply it via gtk-application-prefer-dark-theme, then keep following live changes via the SettingChanged signal. xdg-desktop-portal-gnome wraps the reported value in an extra GVariant "v" layer beyond what the portal spec calls for, so unwrap variant layers in a loop rather than once.
Adds packages/rpm/rustmius.spec plus a build-rpm.sh helper mirroring build-deb.sh: it snapshots the working tree into a source tarball, builds in a private rpmbuild _topdir, and copies the resulting RPMs into dist/. Runtime deps (gtk4, vte291-gtk4, openssl, etc.) are picked up automatically from the linked binary via RPM's find-requires.
Adds an rpm job to the release workflow, mirroring the deb job: it
runs inside a fedora:latest container, reuses the prebuilt generic
x86_64 binary artifact via SKIP_BUILD=1, and uploads the resulting
package for the release job to attach to the GitHub release.
To support SKIP_BUILD, build-rpm.sh now stages a prebuilt binary into
the source tarball when present, and the spec's %build step skips
`cargo build` when it finds one. Also disables Fedora's debuginfo/
debugsource subpackages (%global debug_package %{nil}): every release
channel builds with `strip = "symbols"`, so there's no debug info for
find-debuginfo to extract from a prebuilt binary anyway.
Also ignores stray *.rpm build output and rpmbuild/ trees, matching
the existing deb/AUR artifact ignores.
Owner
|
Thanks for the PR — both features are useful. A few things before merge: Theme sync The portal approach looks right for plain GTK4. One issue in the current code: Minor: RPM packaging
Optional: consider building the binary inside the Fedora container instead of reusing the Ubuntu artifact — not a hard blocker (glibc backward compat should be fine), but cleaner for a Fedora package. Happy to re-review once the proxy lifetime and spec/CI deps are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i switched to Fedora :D
Summary
the desktop's dark-mode preference like libadwaita does, so it uses
color-schemefrom theXDG Desktop Portal and
stardustandappkeep it in sync withEtK application-prefer-dark-theme
Test plan
system dark theme