Repository navigation
fix(translation): show a role's own text when its locale key has no translation - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mods built against MiraAPI 0.4.0 set RoleName / RoleDescription / RoleLongDescription directly and ship no locale files. CustomRoleManager registers the role's vanilla StringName and blurbs under the locale keys (BuildTranslationId: namespace + type name), and MiraLocalizationProvider returned the key itself when it had no translation, so the role screen, intro and settings showed e.g. "PlagueDoctor.Role.PlagueDoctor.PlagueDoctorRole" instead of "Plague Doctor".
GetOrCreateLocaleString gains an overload taking a fallback, used while the key has no translation; the role StringNames pass the role's own RoleName / RoleDescription / RoleMedDescription / RoleLongDescription. Mods with locale files are unaffected: their translation still wins, and the default RoleName already resolves through the same key.
Verified in Freeplay with PlagueDoctor (no locale files): TranslationController.GetString on the role's StringName, BlurbName and BlurbNameLong returned the keys before and "Plague Doctor" and the role's own blurbs after.