Skip to content

Trim redundant tests and align issue triage - #210

Merged
shreyanshjain7174 merged 1 commit into
mainfrom
feat/live-poc
Oct 23, 2026
Merged

shreyanshjain7174 merged 1 commit into
mainfrom
feat/live-poc

Conversation

@shreyanshjain7174

@shreyanshjain7174 shreyanshjain7174 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Remove 15 duplicate or tautological test functions across 7 test files.
The test-only diff removes 418 net lines.
Retained tests cover the same behavior, including validation boundaries.
The unique Argo job-id assertion moves into the stronger workflow test.
No production code, dependencies, APIs, or supported runtimes change.

Remove the nonexistent oss label from the feature form.
Keep native bug and enhancement defaults.
Update contribution guidance and partial-progress issue references.

The attribution trailer was corrected without changing the code tree.
The existing AI Attribution Guard remains unchanged.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • CI/infrastructure

Checklist

  • go build ./... passes
  • go vet ./... passes
  • go test ./... passes (or relevant subset)
  • make test-controller passes (if you changed the API or reconciler)
  • No private-repo content leaked into OSS core
  • Commit is signed off (git commit -s)
  • Commits are human-authored. No AI names in Signed-off-by or Co-authored-by trailers (the AI Attribution Guard rejects Claude, Copilot, Cursor, GPT-*, Codex, etc.)
  • Documentation updated (if applicable)

How to test

Fresh local checks ran on commit 4afe6b33788236986a828658ab6f0a9baf736762:

  • go build ./...: passed, exit 0.
  • go vet ./...: passed, exit 0.

Head 41eba80bebfb9a47db39b969aba17df0550f3662 has the identical code tree.
Only the attribution trailer changed.
Both trees are 6e5c850d9cefa60165b2022bc93c53194e7cd8b4.
CI is rerunning on the new head before merge.

Recorded post-edit checks ran on the same test content before this commit:

  • go test ./api/v1alpha1/ ./pkg/runtime/ -count=1 -v: passed.
    Result: 44 top-level tests and 32 subtests passed.
  • make test-controller LOCALBIN=/Users/sunny/clawdlinux/agentic-operator-core/bin: passed.
    Result: 60 top-level tests, 119 subtests, and 4 Ginkgo specs passed.
  • PYTHONPATH=. /Users/sunny/clawdlinux/agentic-operator-core/.venv/bin/python -m pytest agents/tests/test_workflow.py -v -p no:cacheprovider: passed.
    Result: 6 passed and 1 pre-existing expected failure.
  • go test ./pkg/argo/ -count=1 -run TestWorkflowManager_GetArgoWorkflowStatus -v: passed.
  • git diff --check: passed.

The full go test ./... suite was not run.
Controller validation reused existing envtest assets through the local LOCALBIN override.
Use make test-controller without that override when existing local tools are unavailable.

The before/after run-set comparison lost exactly the 9 approved Go test functions.
Python collection lost exactly the 6 approved functions.
Independent Claude Opus 5.5 review passed spec compliance and code quality.

Related issues

No issue is closed by this PR.
The approved GitHub backlog cleanup was performed separately.

@shreyanshjain7174
shreyanshjain7174 marked this pull request as ready for review October 23, 2026 02:24
Copilot AI balanced review requested due to automatic review settings October 23, 2026 02:24
Remove 15 duplicate or tautological tests. Preserve keeper assertions and boundary coverage.

Keep native issue labels valid and document scope-based triage.

Test implementation and review: Claude Opus 5.5.

Signed-off-by: Shreyansh Sancheti <007ssancheti@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR reports an unresolved AI Attribution Guard failure caused by its Copilot co-author trailer.

No open issues 🎉

What changed in this PR

This PR trims redundant tests across the Go operator and Python agents, then updates contribution and issue-triage guidance.

Changes:

  • Removes 15 duplicate or tautological tests across 7 files.
  • Preserves the Argo job-ID assertion in the stronger workflow test.
  • Removes the oss feature label and clarifies issue references, triage, and project scope.
File Description
pkg/​runtime/​adapter_test.go Removes a tautological phase-assignment test.
internal/​controller/​agentworkload_controller_quota_test.go Removes a duplicate quota test and unused stubs.
internal/​controller/​agentworkload_controller_argo_test.go Removes overlapping tests and preserves the job-ID assertion.
CONTRIBUTING.md Clarifies issue references, triage expectations, and core scope.
api/​v1alpha1/​agentworkload_webhook_test.go Removes overlapping objective-boundary and defaulting tests.
api/​v1alpha1/​agentworkload_compatibility_test.go Removes a redundant bounded-objective test.
agents/​tests/​test_workflow.py Removes dictionary-only assertions that do not exercise workflow behavior.
agents/​tests/​test_state.py Deletes tests that only exercise dictionary behavior.
.github/​PULL_REQUEST_TEMPLATE.md Clarifies closing keywords versus partial-progress references in a template comment.
.github/​ISSUE_TEMPLATE/​oss_feature.yml Removes oss while retaining the enhancement default.

Review effort: Balanced

@shreyanshjain7174
shreyanshjain7174 merged commit 8190530 into main Oct 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants