feat: add bearer token connections - #30
Merged
Merged
Conversation
Signed-off-by: Shreyansh Sancheti <43677304+shreyanshjain7174@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an admin endpoint to connect bearer tokens to existing users for configured bearer services. This fits the gateway model where the vault stores credentials and the proxy injects them upstream.
Changes:
- Add
POST /admin/tokensadmin endpoint to store bearer tokens in the existing encrypted vault. - Gate the endpoint to services configured with
auth.type: bearer. - Add integration tests and README docs for the new endpoint. Wire the route in
cmd/agentgw.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/gateway_test.go | Adds integration coverage for connecting a bearer token and dispatching an action using it. |
| README.md | Documents POST /admin/tokens behavior and request shape. |
| internal/admin/handler.go | Implements ConnectBearerToken and plumbs Registry into the admin handler. |
| cmd/agentgw/main.go | Wires the new admin route into the production server. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+152
to
+154
| req.UserID = strings.TrimSpace(req.UserID) | ||
| req.Service = strings.TrimSpace(req.Service) | ||
| if req.UserID == "" || req.Service == "" || strings.TrimSpace(req.AccessToken) == "" { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Verification:
All passed locally. Semgrep reported 0 findings.