Repository navigation
Add Sheets SDK samples - #239
Merged
Merged
Conversation
| client=self._api_client) | ||
| sort = SheetSort(order_by=order_by if order_by is not None else UNSET, | ||
| order=order if order is not None else UNSET) | ||
| return query_sheet_data.sync(project_id=project_id, |
Member
There was a problem hiding this comment.
Is this duplicated from below?
Contributor
Author
There was a problem hiding this comment.
Yes, but it allows you to not have to construct the passed in SheetDataRequest. Happy to just remove it since we aren't live yet. Probably easier.
Member
There was a problem hiding this comment.
yeah we probably don't need an extra method for that. Maybe make the request object optional and provide reasonable defaults if it's not set.
Contributor
Author
There was a problem hiding this comment.
Sounds good. Updated.
|
nathanthorpe
approved these changes
Oct 23, 2026
nathanthorpe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_sheet_data was removed. Also, adds in some sample notebooks for doing basic Sheet tasks, remove audit read access, and fixes a bug as we need to pass in the sheet type.