test(scoreboards): pin every plugin's game-over check before family 5 reconciles it - #621
Open
ChuckBuilds wants to merge 1 commit into
Open
ChuckBuilds wants to merge 1 commit into
ChuckBuilds wants to merge 1 commit into
Conversation
…s reconciled SportsLive._is_game_really_over has five bodies across the nine scoreboards (afl/nrl/soccer; baseball/ufc; basketball/lacrosse; football; hockey), and the reconcile that makes them one must change only the cells the owner decides. scripts/test_game_over_check.py builds each plugin's real live manager and records its answer for ESPN status x clock x period (missing, 1..6), edge shapes (null/non-numeric fields, non-string clocks, a tie at the end of regulation) and ufc's recorded MMA payloads, against committed tables of today's behaviour. It also checks every league's live manager in a plugin resolves the same method, so one manager per plugin covers them all. Test-only: no plugin code changes, so no version bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 48 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the "reconcile, then promote" procedure (core
docs/SPORTS_UNIFICATION.md) for family 5, the game-over checkSportsLive._is_game_really_over. It only adds a test; no plugin code changes.scripts/test_game_over_check.pybuilds each of the nine plugins' real live managers, using a fake display and cache, and pins 3,115 answers to tables of today's behaviour:period_text, period None, "OT" or "4", an integer or float clock, ties at the end of regulation, and "Final/OT"._extract_game_details.--printregenerates the tables. A failure names the row and the plugins whose answer changed, so the reconcile PR will show exactly which cells it changes.Today's variants (drift report)
Verification
scripts/test_*.pypass against core main.check_version_bumpreports nothing to bump.🤖 Generated with Claude Code