Plugin-wide bug and docs pass (41 plugins) - #611
Merged
Merged
Conversation
Bug fixes: - cricket: innings parsing (bowling innings, 0/0 for sides yet to bat, double highlight), winner flag read as truthy string, Test day/status line, chase line overflow, late live pickup; harness fixture now offline - of-the-day: IndexError after midnight rollover; upload path traversal; day 366 accepted by save/upload scripts - ledmatrix-elections: called-race snapshot expired after 5 min (lost on restart); malformed calendar_events date broke every update - pomodoro-timer: inf/overflow durations wedged the timer - on-air: republish retained state on connect; real sw_version - mqtt-notifications: BDF fonts never rendered; image retry per frame - tide-display: honour the core's display_mode (disabled modes took a turn) - news: empty <description/> failed the whole feed - calendar: sort events by real start time across calendars - static-image: error screen drew on the discarded image; zero-height fit - countdown: oversized image-right pushed text off panel - soccer custom leagues, f1 auto_scale, youtube-stats cache key, music album-art cache, stocks switch-mode layout, blackjack color-picker, christmas-countdown "1 DAY", hello-world font-manager None check, birdnet photo retry, basketball/baseball missing layout settings Docs: READMEs reconciled with schemas and code across all bumped plugins; repo docs fixed (required manifest fields, new plugins need a hand-added plugins.json entry, core API signatures, CI workflow names); README screenshots regenerated for christmas-countdown, hello-world, 7-segment-clock and ledmatrix-stocks. scripts/test_stage3_mixin_copies.py: list the three SportsFetchMixin methods core added in LEDMatrix#728. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 55 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ocs-7319c2 # Conflicts: # scripts/test_stage3_mixin_copies.py
Codacy flagged three issues new in this PR: - cricket manager _upcoming_has_started: try/except/continue around .timestamp() -> skip entries without a datetime instead. - cricket manager on_config_change: try/except/pass closing the old session -> only close a session that exists, log a failure at DEBUG. - afl test_afl_plugin.py: importlib.import_module(name) takes only the fixed module names the test passes; marked nosemgrep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full audit of every plugin plus the repo docs. 41 plugins get patch bumps, and basketball and baseball get minor bumps. Each version has a new
versions[0]entry, andplugins.jsonis regenerated withupdate_registry.py.Bugs users would hit
"false"winner flag was read as true, so both sides drew in the winner's green.upload_file.py.calendar_eventsdate broke every update.infor overflowing duration left the timer stuck on its error screen.sw_versionis read from the manifest.display_mode, so a disabled screen no longer takes a turn.<description/>failed the whole feed.image-rightand an oversized image, the countdown text was pushed off the panel.auto_scaledid nothing for a custom TTF font.channel_id.x-widget: colorchanged tocolor-picker.Docs
manifest_schema.json.plugins.jsonentry.needs_high_fpsnote and CI workflow names.Tooling
scripts/test_stage3_mixin_copies.pynow lists the threeSportsFetchMixinmethods core added in LEDMatrix#728. Without this, the test fails on current core.Verification
scripts/test_*.pyand everycheck_*.pypasses, run against a fresh export of LEDMatrixorigin/main.update_registry.py --checkpasses.check_plugin.pypasses at all 8 sizes for every changed plugin, and the rendered images were looked at, not just the PASS lines.Not changed (needs a decision)
🤖 Generated with Claude Code