scripts: catch the guards up with core main (#733's display_arbiter, #728's fetch mixin methods) - #610
Merged
Conversation
Core main gained src/display_arbiter.py (run() stage 2, unreleased), so the min-core guard fails every plugins PR until the table names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
… guard Core #728 (fetch service stage 2) added _schedule_cache_key, _cached_schedule and _retire_previous_window to SportsFetchMixin; the guard requires every mixin name to be listed, so it failed every plugins PR's safety job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChuckBuilds
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two core merges broke the plugins safety job for every PR:
src/display_arbiter.py. It's now listed incheck_min_core_version.py's table asNone(on core main, in no release yet)._schedule_cache_key,_cached_scheduleand_retire_previous_windowtoSportsFetchMixin. They're now listed intest_stage3_mixin_copies.py, which requires every mixin name. No plugin defines a copy.With
LEDMATRIX_COREat core main a5ec645d, everyscripts/test_*.pypasses.🤖 Generated with Claude Code