fantasy-blitz: Vegas static shows every screen, fixed scrolls panel blocks (1.1.1) - #609
Merged
Merged
Conversation
…locks (1.1.1) static: Vegas pauses the scroll and calls display() once with no mode, then waits. The plugin resolved that to the first mode every time, so the pause always showed the top scorers' first card. Each pause now shows the next screen in the playlist (then the next item of each). fixed: behaved identically to scroll although documented as scrolling the whole panel as one block. It now scrolls each screen as a panel-sized block, up to 3 items per screen. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 36 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
display()once, with no mode, then waits forget_display_duration(). The plugin resolved that call to the first mode every time, so every pause showed the top scorers' first card and the other screens never appeared. Each pause now shows the next screen in the playlist (then the next item of each once the playlist has been round). Vegas never redraws during a pause, so it is one finished still frame per pass.scrollin both the plugin and the core, although documented as scrolling the whole panel as one block. It now scrolls each screen as a panel-sized block (max 3 items per screen).Caveat
I could not reproduce a "fixed shows nothing" crash: on the board's core, fixed and scroll return the same cards (fixture and live data, 512x64), and the journal has no errors. The reporter's board is on 1.0.2. This PR makes fixed do what it documents, but it is not a confirmed fix for that report.
Testing
check_plugin.pypasses on every panel size.check_version_bump.py --allpasses;plugins.jsonregenerated.🤖 Generated with Claude Code