nfl-stat-leaders: read season-scoped ESPN core leaders API (1.0.2) - #608
Merged
Merged
Conversation
The site.web common/v3 and site/v2 leaders endpoints now return 404, so the
plugin showed nothing. Fetch from sports.core.api.espn.com
.../seasons/{season}/types/{type}/leaders instead. Leaders there reference
the athlete rather than embedding it, so names and positions are resolved
once per player in update() and cached for a month, stopping early after
repeated lookup failures.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 32 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site.web.../common/v3/.../leadersandsite/v2) now return 404, so the plugin displayed nothing.https://sports.core.api.espn.com/v2/sports/football/leagues/nfl/seasons/{season}/types/{type}/leaders. The unscoped/leagues/nfl/leadersreturns all-time career leaders and ignores the season.update()and cached for a month; lookups stop for a refresh after 3 consecutive failures.Test plan
update_registry.py --check,check_version_bump.py --all,check_module_collisions.pypass🤖 Generated with Claude Code