feat(baseball-scoreboard): game activity pop-ups for the live scorebug (1.56.0) - #606
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 1010 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…g (1.56.0) A one-line banner along the bottom of the live scorebug for the plays between runs, as the hockey scoreboard does for shots and penalties. Off by default, MLB and NCAA only. Rebased onto main after the celebrations PR was squashed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ChuckBuilds
force-pushed
the
claude/baseball-game-activity
branch
from
October 2, 2026 21:19
0b5aa00 to
43c19f7
Compare
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #605 (celebrations and scorer card); the base branch is that PR's, so this diff is only the pop-ups. GitHub retargets it to
mainwhen #605 merges.What
Hockey has a game-activity banner; baseball had nothing like it. This adds one: a one-line banner along the bottom of the live scorebug for the plays between runs, held for a few seconds, then faded back to the scorebug.
Harper SINGLE! Top 8thAcuna Jr. STEALS 3RD Bot 1stMcFarlane IN RELIEF Bot 7thRuns are left to the celebration and the scorer card, as hockey leaves goals: a play flagged
scoringPlayis never a pop-up.How
ESPN's baseball summary has one row per pitch plus a
play-resultrow per at-bat ("Harper singled to left, Turner scored."). Checked against the real PHI @ ATL summary from 2026-09-30 (623 rows): the pop-up is built from the result sentence, pitch rows and lineup bookkeeping are ignored, and none of the game's 7 runs came through. It polls the same summary the celebration and scorer card read, for the game on screen, in a thread, and shares the celebration's fetch when a run has just scored. The render path only reads a queue.1B,SB,K), the short inning (T8), then the inning itself. Accents are folded (Acuna) because the 4x6 face has no n-tilde.Settings (per league, MLB and NCAA only; MiLB has no play data)
display_options.show_game_activity(off),game_activity_detail(highlights; orhits_and_steals,everything),game_activity_dwell_seconds(6),game_activity_fade_seconds(3). Only on panels 32 px tall or more. One extra ESPN request per live update for the game on screen. Forwarded by_adapt_config_for_manager; README, schema and CHANGELOG updated.Files
New:
baseball_activity.py,test_baseball_activity.py. Edited:baseball.py(mixin, poll inupdate(), one call before the frame is presented),baseball_celebration.py(_fetch_summarytakes a timeout), manager, schema, README, CHANGELOG, manifest 1.55.0 -> 1.56.0,plugins.json.sports.pyis untouched.Tests
test_baseball_activity.py: extraction, wording, queue and poll rules, fade, every panel size 64x32 to 256x64, and a pass over the real ESPN game when$TMP/sum.jsonis present.test_odds_placement, which fails the same way onorigin/main.check_plugin.pyon this branch, or against a live game.Known limits
The banner covers the scorebug's bottom row (the team abbreviations and scores in the corners) while it shows, as hockey's does.
🤖 Generated with Claude Code