blackjack/calendar/olympics off get_supported_vegas_modes; scoreboard has_live_content re-log at DEBUG; baseball CHANGELOG backfill - #604
Merged
Conversation
Core deprecated BasePlugin.get_supported_vegas_modes() for removal in 3.9.0 (core #682). Core never read it, so the overrides were dead code; blackjack also called its own override to validate vegas_mode. - blackjack 1.3.1: the honoured vegas_mode values (fixed, static) are a module constant. No manifest vegas_participation on purpose: Vegas derives it from get_vegas_display_mode(), and that call is what tells display() a STATIC pause is starting. - calendar 1.2.10, olympics 3.1.4: drop the override. Participation still comes from get_vegas_display_mode() / get_vegas_content_type(). Core floors unchanged (3.2.0, 3.3.0, 2.0.0): nothing new from core is used. The plugin-development doc no longer lists the hook and points at vegas_participation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ackfill The six scoreboards (baseball, basketball, football, hockey, lacrosse, ufc) logged the has_live_content() summary at INFO once a minute even when nothing had changed: a persistent-journal line a minute, each an SD write. It is now INFO only when the answer changes and DEBUG for the periodic re-log. The baseball/football/ufc throttle tests now assert the re-log is DEBUG and not INFO. Stage 4 did not move has_live_content() into core (sports_plugin_host only calls it), so the change belongs here. baseball-scoreboard's CHANGELOG also gains the missing 1.54.1 (#588) and 1.54.2 (#593) entries. Bumps: baseball 1.54.4, basketball 1.41.2, football 3.18.4, hockey 1.42.1, lacrosse 1.36.2, ufc 1.19.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small follow-ups, one commit each (plus the registry regeneration).
1. blackjack, calendar, olympics: off
get_supported_vegas_modesCore deprecated
BasePlugin.get_supported_vegas_modes()for removal in 3.9.0 (LEDMatrix #682). Core never read it. Vegas participation comes from the user'svegas_participation, then the manifest, thenget_vegas_display_mode()/get_vegas_content_type(). So the overrides were dead code. Blackjack also called its own override, to validatevegas_mode.vegas_modevalues (fixed,static) are now a module constant_VEGAS_MODES_OFFERED. The override is removed.None of the three declares a manifest
vegas_participation, on purpose. Each one's participation depends on state or config: blackjack and calendar onvegas_mode, olympics on live medal finals andvegas_mode, calendar and olympics on whether there is any content. A fixed manifest value would override all of that. For blackjack it would also stop theget_vegas_display_mode()call thatdisplay()uses to detect the start of a STATIC pause. The legacy hooks are still how core derives these plugins' participation, and that is documented and not deprecated. Core floors are unchanged (3.2.0, 3.3.0, 2.0.0) because nothing new from core is used.docs/plugin-development/03-advanced-features.mdno longer lists the hook. It now points atvegas_participation.2. Scoreboards:
has_live_content() returning ...re-log at DEBUGAll six scoreboards still had this. Stage 4 did not move
has_live_content()into core:src/common/sports_plugin_host.pyonly calls it, so the change belongs here. The summary is now logged at INFO only when the answer changes. That means the state tuple each plugin already compares: the boolean, the per-league flags, and the live counts where the plugin tracks them. The once-a-minute re-log of an unchanged answer is now DEBUG. At INFO it was one persistent-journal line a minute, measured at ~9 KB stored per line.The baseball, football and ufc throttle tests now assert that the interval re-log is DEBUG and not INFO. I mutation-checked them: putting INFO back fails one test in each.
Each scoreboard has a new
versions[]entry and a CHANGELOG entry.3. baseball-scoreboard CHANGELOG backfill
Adds the missing 1.54.1 entry, written from #588's description. 1.54.2 (#593) was missing too, so it is added from #593's description.
Verification
resolve_vegas_participationfrom core main): I loaded each plugin from main and from this branch through core'sPluginLoader, with the manifest registered so manifest participation is read. Across 46 cases I recorded participation,get_vegas_display_mode(), content type and a pixel hash of everyget_vegas_content()image. The results are identical. A main-vs-main control run was also identical. No case logged anything aboutget_supported_vegas_modes. The cases:vegas_modedefault,fixed,static,scroll(not offered, falls back to fixed) and invalid; userexcludeandpause. Each at 128x32, 64x32 and 192x48.vegas_modedefault,static,fixedand invalid; userpause. Each with no events and with two events.vegas_modedefault,staticandfixed; alerts off; userexclude. Each with no data, a countdown, and live finals.scripts/run_plugin_tests.pyon the 9 touched plugins, core = LEDMatrix origin/main): main gives 254 passed and 2 failed, and this branch gives the same 254 passed and the same 2 failed. Both failures are on main too:baseball-scoreboard/test_odds_placement.pyand the interactivefootball-scoreboard/test_football_plugin.py.scripts/test_*.pypass on both main and this branch, withLEDMATRIX_COREpointing at core main. This includestest_check_sports_drift, which watcheshas_live_contentacross siblings.check_version_bump.py --base origin/mainpasses with the 9 ids.update_registry.py --checkpasses.🤖 Generated with Claude Code