perf(fetch): cache ESPN scoreboard windows without the parts nothing reads

[ChuckBuilds]

Summary

The sports scoreboards cache their Recent/Upcoming window (14 days back, 7 ahead) as the raw ESPN response, and while it's fresh it stays parsed in the memory tier. Most of it is never drawn. BackgroundDataService now drops those parts of an ESPN /scoreboard response before caching and delivering it (src/common/espn_payload.py):

removed	where
leaders	per-competitor and per-competition stat leaders
probables, status.featuredAthletes	athlete cards with headshots and season stats
team.links, event.links	web and app URLs
headlines, highlights	article and video blurbs
geoBroadcasts	regional broadcast details

Everything else is kept, including odds, records, linescores, situation, statistics, notes, broadcasts and venue. Only those exact keys are ever removed. submit_fetch_request(..., slim_payload=False) caches a response whole.

On the four hdpi windows (MLB, college football, NHL, NFL) this takes the JSON from 10.6 MB to 3.0 MB and the parsed objects from ~40 MB to ~12 MB. Parsing an expired window, which some scoreboard paths do on the render thread, gets 3–4x cheaper.

Type of change

• Bug fix (performance / memory)

Test plan

• Render equivalence, against ledmatrix-plugins main (f568fd3) and this branch rebased on 07abd87: I ran scripts/check_plugin.py for baseball (MLB), football (NFL, and college football with ncaa_fb enabled) and hockey (NHL) at every size, seeded with the real hdpi windows, once raw and once slimmed. Records, odds and rankings were switched on. 88 PNGs, all byte-identical. They show real games (e.g. PHI–ATL Final 2–6, Stable #3 Notre Dame vs UNC).
• Nothing reads the removed keys. I grepped core and every plugin on ledmatrix-plugins main. The only hits are leaders in f1-scoreboard and nfl-stat-leaders, which read different ESPN APIs (not /scoreboard, not via this service), and "highlights" in baseball-scoreboard, which is a config value, not a payload key.
• Ran on a real Raspberry Pi with hardware: hdpi (Pi 4, 512x64), 75-min windows from a fresh restart, main then this branch. RSS was 30–40 MB lower at every 10-minute mark (306–326 vs 337–385 MB). Late frames were 4.7 vs 4.1 per 1,000, with no regression.
• Ran the test suite (pytest): new test_espn_payload.py checks that exactly the listed keys go and everything else is unchanged, that odd shapes pass through, that the URL check rejects look-alike hosts, that the service caches and delivers the same slimmed object, the opt-out, and that other URLs are untouched. 145 related tests pass.

Notes for reviewer

• The single-day scoreboards fetched through APIHelper / store_espn_scoreboard_cache (feat(fetch): one ESPN scoreboard cache key and a max-age response cache (fetch service stage 2) #728's shared key) aren't slimmed. They're small and outside this change's scope.
• A plugin that later wants one of the removed fields must pass slim_payload=False. The module docstring says so.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 29b029f1-8335-434f-8097-5b541d011ba3

📥 Commits

Reviewing files that changed from the base of the PR and between 07abd87 and 00456eb.

📒 Files selected for processing (3)

• src/background_data_service.py
• src/common/espn_payload.py
• test/test_espn_payload.py

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category	Results
ErrorProne	1 high

View in Codacy

🟢 Metrics 20 complexity

Metric	Results
Complexity	20

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}