Skip to content

Fix screen reader names for remaining top-bar controls - #4992

Merged
ChrisTitusTech merged 1 commit into
ChrisTitusTech:mainfrom
malinfossum:fix/topbar-a11y-names
Aug 19, 2026
Merged

Fix screen reader names for remaining top-bar controls#4992
ChrisTitusTech merged 1 commit into
ChrisTitusTech:mainfrom
malinfossum:fix/topbar-a11y-names

Conversation

@malinfossum

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • UI/UX improvement

Description

PR #4944 added AutomationProperties.Name to SettingsButton and the window controls, but four top-bar controls were left unnamed, so screen readers (Narrator, NVDA) announce them by their raw content:

  • ThemeButton — announced as "N/A" (placeholder content, glyph set at runtime)
  • FontScalingButton — announced as raw Unicode \uE8D3 (ironically, the accessibility button)
  • SearchBar — an unnamed edit field
  • SearchBarClearButton — announced as "X"

This adds AutomationProperties.Name to all four, completing the top-bar naming pass. XAML-only change; verified with .\Compile.ps1 -Run + Narrator, and the full Pester suite passes (549/549).

Issue related to PR

ThemeButton, FontScalingButton, SearchBar, and SearchBarClearButton had
no AutomationProperties.Name, so screen readers (Narrator, NVDA)
announce them as raw glyph text ("N/A", Unicode E8D3), an unnamed edit
field, and a button called "X". Completes the top-bar naming pass
started for SettingsButton and the window controls.
@github-actions github-actions Bot added bug Something isn't working ui update UI/UX improvements labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3570b911-f17c-4dc6-8c73-c4b3815eb6d2

📥 Commits

Reviewing files that changed from the base of the PR and between 3f1850f and 94b8b70.

📒 Files selected for processing (1)
  • xaml/inputXML.xaml

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Accessibility
    • Added accessible labels to the search box, search-clear button, theme button, and font-scaling button.

Walkthrough

Added AutomationProperties.Name values to the search box, search-clear button, theme button, and font-scaling button in the XAML input layout.

Changes

Accessibility labels

Layer / File(s) Summary
Control automation names
xaml/inputXML.xaml
Added descriptive automation names for the search field, search-clear button, theme button, and font-scaling button.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 94b8b

This PR adds accessible names to four top-bar controls through a localized XAML-only change. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main accessibility change for the remaining top-bar controls.
Description check ✅ Passed The description directly explains the four accessibility fixes, affected controls, implementation, and verification results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChrisTitusTech
ChrisTitusTech merged commit b21d416 into ChrisTitusTech:main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui update UI/UX improvements

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants