Fix screen reader names for remaining top-bar controls - #4992
Conversation
ThemeButton, FontScalingButton, SearchBar, and SearchBarClearButton had
no AutomationProperties.Name, so screen readers (Narrator, NVDA)
announce them as raw glyph text ("N/A", Unicode E8D3), an unnamed edit
field, and a button called "X". Completes the top-bar naming pass
started for SettingsButton and the window controls.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded ChangesAccessibility labels
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR adds accessible names to four top-bar controls through a localized XAML-only change. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Type of Change
Description
PR #4944 added
AutomationProperties.NametoSettingsButtonand the window controls, but four top-bar controls were left unnamed, so screen readers (Narrator, NVDA) announce them by their raw content:\uE8D3(ironically, the accessibility button)This adds
AutomationProperties.Nameto all four, completing the top-bar naming pass. XAML-only change; verified with.\Compile.ps1 -Run+ Narrator, and the full Pester suite passes (549/549).Issue related to PR