fix(queue): bind cache operations to request and credential lifetimes by Chris0Jeky · Pull Request #3349 · Chris0Jeky/Taskdeck

Chris0Jeky · 2026-09-21T15:42:50Z

Closes #3348. Related residual: #3352.

Summary

Binds queue request-list, stats, mutations, loading, errors and session settlement to explicit owners:

request-list queries share one latest owner; stats use an independent read lane;
confirmed submit/cancel/non-empty processNext advances a mutation generation and invalidates older snapshots;
loading derives from active operation tokens;
error receipts are scoped to request-list, stats or mutation work, so unrelated operations cannot erase current failures;
identity/auth/demo replacement clears queue data and retires all work;
same-user token rotation preserves settled request/stat caches and suppresses old-token settlement;
active empty request/stat reads restart under the new token, retaining the exact user/status query;
submit, cancel and process mutations are never replayed.

Same-target mutation serialization and backend/cross-device concurrency remain outside this parent.

Test-first evidence

Initial test-only head 1a21444f8a29c160bce124e3c3372142854f67bd ran canonical Ubuntu/Windows frontend qualification and produced exactly ten intended ownership failures. Cross-lane error review-regression head 5c39c1c92c8e5792a8461228fd33a561683559e7 passed lint, typecheck, build and PWA validation before JUnit recorded 7,161 tests, exactly 1 failure, 0 errors: a stats refresh erased the current request-list failure.

Issue #3352 added test-only head 9d67a15d8e8a41dd253328344afcd435b339c3e5, covering token rotation while a Failed request query and stats read are still empty. A dependency-free actual-module runner changed from one call per lane with loading false to two calls per lane, exact Failed filter replay, old settlement suppression and fresh results installed.

Supplemental execution does not replace hosted qualification.

Current head and remaining gates

Exact final head: 89da656b592e4e2c1c8f6065c36e55647b8ae168

Keep draft until this exact head passes Smart CI, Extended and the complete Required CI matrix on Ubuntu and Windows, followed by fresh-context review.

No backend, route, DTO, schema, migration, dependency, workflow or control-plane change. Green CI is qualification evidence, not merge authorization.

chatgpt-codex-connector · 2026-09-21T18:59:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-22T00:18:49.418793Z	`ff2bdf8`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89da656b59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T20:28:23Z

@codex review

Please review exact current head 43dfb6f against base fb830ed. This is the one current-head review request after the main-base requalification. Focus on the PR's changed ownership and stale-settlement behavior, and report only merge-blocking correctness or security defects.

chatgpt-codex-connector · 2026-09-21T20:32:25Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 43dfb6f61c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T21:38:05Z

@codex review Please review the exact current head 4aa8a83, including active-filter retry and joined replacement-read behavior after token rotation, plus the failure-path regression test. Treat prior review threads as triaged; report only merge-blocking correctness or security defects at this exact head.

chatgpt-codex-connector · 2026-09-21T21:42:17Z

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 4aa8a83cae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T22:06:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a0b60003d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T22:29:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4527e2c573

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T22:38:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcbbc38f21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T23:16:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67280f2fc6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-21T23:30:45Z

@codex review

chatgpt-codex-connector · 2026-09-21T23:37:31Z

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 2bf7f83487

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-09-22T00:13:34Z

@codex review

chatgpt-codex-connector · 2026-09-22T00:18:48Z

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: ff2bdf89ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-project-automation Bot added this to Taskdeck Execution Sep 21, 2026

github-project-automation Bot moved this to Pending in Taskdeck Execution Sep 21, 2026

This was referenced Sep 21, 2026

Feature-flag restore accepts non-boolean route gates and can crash on storage failure #3350

Open

Same-user token refresh can strand empty first-load store surfaces #3352

Open

Chris0Jeky marked this pull request as ready for review September 21, 2026 18:59

Chris0Jeky force-pushed the audit/3348-queue-operation-ownership branch from 89da656 to 4db70b5 Compare September 21, 2026 19:02

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/store/queueStore.ts Outdated

Comment thread frontend/taskdeck-web/src/store/queueStore.ts Outdated

Chris0Jeky force-pushed the audit/3348-queue-operation-ownership branch from 4db70b5 to 43dfb6f Compare September 21, 2026 20:16

Chris0Jeky force-pushed the audit/3348-queue-operation-ownership branch from 4aa8a83 to 6a0b600 Compare September 21, 2026 22:06

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/store/queueStore.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/store/queueStore.ts

Comment thread frontend/taskdeck-web/src/store/queueStore.ts

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/store/queueStore.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/store/queueStore.ts

Chris0Jeky force-pushed the audit/3348-queue-operation-ownership branch from 67280f2 to 2bf7f83 Compare September 21, 2026 23:24

Chris0Jeky added 5 commits September 22, 2026 01:06

test(queue): reproduce cache and session ownership races

c787160

fix(queue): bind cache operations to credential lifetime

c25855c

test(queue): preserve cached data across token refresh

bce5783

fix(queue): preserve cached data across token refresh

53499cb

test(queue): pin cross-lane error ownership

882fa23

Chris0Jeky and others added 8 commits September 22, 2026 01:06

fix(queue): scope shared error receipts to their operation

ff2c580

test(queue): retry empty initial reads after token refresh

46d1cca

fix(queue): retry empty active reads after token refresh

77a73df

fix(queue): join token-refresh read retries

e068ce7

test(queue): cover failed token-refresh retry

a81daa5

fix(queue): reconcile stale mutations after token refresh

bf19518

fix(queue): guard token retries after logout

2ded16d

fix: preserve queue query after token refresh

ff2bdf8

Chris0Jeky force-pushed the audit/3348-queue-operation-ownership branch from 2bf7f83 to ff2bdf8 Compare September 22, 2026 00:06

Conversation

Chris0Jeky commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test-first evidence

Current head and remaining gates

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Chris0Jeky commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026

Uh oh!

Chris0Jeky commented Sep 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Chris0Jeky commented Sep 21, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 21, 2026 •

edited

Loading