fix(notifications): serialize preference saves by intent - #3343
Draft
Chris0Jeky wants to merge 4 commits into
Draft
Chris0Jeky wants to merge 4 commits into
Chris0Jeky wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3341.
Stack
Stacked on PR #3340 (
audit/3339-notification-read-ownership) at parent head49b903a61a744061f04511377a97f2807dfeed1b.Retarget to
mainonly after #3340 lands, verify the child-only diff, then requalify the resulting exact head.Summary
Serializes notification preference saves in this client’s submission order:
This queue does not claim cross-device concurrency safety or add a backend revision precondition.
Test-first evidence
4f89c6f2969d5dbad923841b4984ef152daef824af8fde45f58f9dab0027ce11e7530ca03e2f2d2e0d1ef8e21cc15f94f3bb86f3d86f21097432c0a99e6b675805e6b100952743d900b1458ae7888746The committed Pinia/Vitest suite covers:
A supplemental runner transpiled and executed the actual stores:
The production module and current test file transpile under TypeScript 5.8.3 with zero diagnostics.
Hosted qualification history
At
0d1ef8e21cc15f94f3bb86f3d86f21097432c0a9, Self-Test and Extended passed. Required CI failed before typecheck/tests because the new test file retained one unused localnotification()factory. Ubuntu and Windows reported the same@typescript-eslint/no-unused-varserror; backend unit/API integration, architecture, migrations, security, governance and worktree lanes were green. Container frontend build failed downstream of the same frontend source gate.Current head
9e6b675805e6b100952743d900b1458ae7888746removes only that unused factory. Runtime source and behavioral assertions are unchanged. Its exact-head workflows are pending.Keep draft until the complete current-head Self-Test, Extended, Required CI and independent review are inspected. After #3340 merges, retarget to current
main, verify the child-only diff and rerun all qualification. Green CI will be evidence, not merge authorization.