fix(integrations): bind connector reads to request lifetimes - #3329
Open
Chris0Jeky wants to merge 2 commits into
Open
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
Owner
Author
|
Fresh source-backed verification for exact head
The actual-module runner uses only framework/API boundary stubs and does not replace canonical Pinia/Vitest or full hosted qualification. The test-only Required run was superseded/cancelled, so this comment does not claim a hosted canonical-red execution. |
This was referenced Sep 21, 2026
Chris0Jeky
marked this pull request as ready for review
September 21, 2026 14:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3327.
Summary
Binds integration list/detail reads to explicit request lifetimes instead of entity ID or one shared Boolean:
finallysettlement cannot alter the replacement lifetime;The integration API, DTOs, routes and mutation behavior are unchanged. This slice does not claim to cancel or roll back a connector mutation already accepted before reset.
Test-first evidence
Base:
307c3b8b50bec1cb0bfaea3e570a942bcb1d445178ecac7d3bc37fe80ba1c746f0eecb9e6d72f3724e232e22778489681b9db5746e5c221ada7a088aA supplemental runner transpiled and executed the actual production store with only its framework/API boundaries stubbed:
main: 0/5 ownership schedules passed;The committed Pinia/Vitest suite covers six schedules:
The test-only Required CI was superseded and cancelled when the corrective head was pushed, so no hosted canonical-red claim is made. Smart CI and Extended passed on the test-only commit; canonical regression qualification belongs to the corrective exact head.
Verification
Local/source-backed:
Hosted exact-head:
35597534968: success;35597535200: success;35597535219: success across the complete required matrix.Ready for independent review. Green CI is qualification evidence, not merge authorization. Review should focus on A→B→A identity reuse, reset ownership, stale error/toast suppression, and independent list/detail loading.
No merge, release or deployment qualification is claimed.