Skip to content

test(ci): inventory Windows-capable workflows and reusable callers - #3297

Merged
Chris0Jeky merged 11 commits into
mainfrom
codex/3170-runner-inventory-prerequisite
Sep 22, 2026
Merged

Chris0Jeky merged 11 commits into
mainfrom
codex/3170-runner-inventory-prerequisite

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Scope

A bounded, non-activating prerequisite for #3170 (CI-17); refs #2337 and the difficult-issue map in #3281. This does not close #3170 or implement the private-cutover rehearsal guard.

Based on main 307c3b8b50bec1cb0bfaea3e570a942bcb1d4451. The uploaded ZIP was 45 commits behind, but GitHub comparison confirmed the workflow/Smart CI/policy inputs are unchanged. Remote commits use actual main ancestry and add only four new files; unrelated backend/frontend changes and other sessions' #3295/#3296 work are preserved.

Changes

  • Add a dependency-free conservative inventory of runner jobs and local reusable-workflow call edges.
  • Discover 36 workflow files, 50 runner jobs and 41 reusable calls; record the five Windows/opaque sites and every transitive caller job.
  • Keep expressions, matrices, groups, arrays, aliases and unknown labels visible; do not interpret conditions or pretend a caller's platform: linux proves scheduling safety.
  • Report incomplete discovery for unsupported structural YAML, duplicate keys/files, ambiguous jobs, missing/external callees, cycles and source-limit violations.
  • Add a reviewed drift snapshot and 47 focused tests, automatically included by the existing Smart CI test glob.
  • Document usage, evidence and the separation between inventory completion and trusted rehearsal authorization.

graphComplete and CLI exit 0 mean discovery succeeded, not zero Windows work, guarded execution or permission to skip CI. This is a deliberately limited block-mapping scanner, not a general YAML parser, Actions validator or protected-base policy. The snapshot is PR-editable and is not a security boundary. No workflow, policy, required check, runner association, credentials, visibility, budget or human acceptance box changes.

Current source and verification

Source head: 5cfa0eb481a2fe38732f1d71e1d6a4866fb1698f. All four remote blob hashes match the verified local files. The initial snapshot transcription omitted one word in a workflow description; this was corrected before the current-head hosted run.

Hosted evidence observed at this exact source head:

  • Smart CI Self-Test passed: run 35516849706, job 106094137527. Logs show Ubuntu 24.04.5 / Node v24.13.1, synthetic merge 22957820aeb51e0811a1afd6f04dfeeafb0e84fe (5cfa0eb into 307c3b8), 601 tests passing, zero failures/skips/cancellations, and the external action-pin guard passing.
  • CI Extended passed: run 35516849980.
  • Required CI still in progress: run 35516849908 at the latest read. This is not full-matrix qualification.
  • Fresh-context Codex review requested on this exact head; a request is not approval.

Local Linux / Node 22.16.0:

  • 47 focused tests passed; all 601 Smart CI tests passed, no failures/skips.
  • Repeated all 601 in a clean detached worktree at frozen local source; it stayed clean.
  • Local independent PyYAML 6.0.3 cross-check matched all 50 runner-job and 41 call-job identities; no PyYAML dependency is introduced.
  • Mutations dropping opaque sites, omitting caller traversal and ignoring duplicates were killed by 11, 4 and 3 tests respectively. No mutation or literal-only negative control is committed.
  • Docs governance, relative links and diff whitespace checks passed. Three pre-existing masking warnings remain in historical/template documents.

Local or hosted Linux junction execution is not Windows runtime qualification; unrelated .NET/frontend suites were not run locally. Exact-head status changes and review findings will be recorded in comments as observed.

Remaining work and review authority

Trusted-base mode propagation, real guard coverage, non-vacuous Linux/security evidence, receipts and the public/private rehearsal matrix remain separate #3170 work. Do not auto-merge. R4 requires maintainer review plus fresh-context review (or an explicit ruling naming this PR). J.3(b)/J.4 human decisions remain unchanged; canonical OUTSTANDING_TASKS.md J.2 registration needs coordinator follow-through. Draft retained while exact-head checks/review are pending.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact source head 5cfa0eb481a2fe38732f1d71e1d6a4866fb1698f against main 307c3b8b50bec1cb0bfaea3e570a942bcb1d4451 for the #3170 discovery prerequisite. Focus on silent runner omission at the supported YAML structural boundary, opaque/dynamic selector retention, duplicate/ambiguous mapping handling, complete local call graphs including multiple transitive callers, bounded traversal, and snapshot drift coverage. Treat the scanner's documented non-goals accurately: no general YAML/Actions validation, expression evaluation, authenticated source identity or rehearsal guard is implemented; graphComplete is never CI-suppression authority.

Observed current-head hosted evidence: Self-Test run 35516849706, job 106094137527. Logs show Ubuntu 24.04.5, Node v24.13.1, synthetic merge 22957820aeb51e0811a1afd6f04dfeeafb0e84fe (5cfa0eb into 307c3b8), all 601 tests passing, zero failures/skips/cancellations, and the action-pin guard passing. Linux/Node22 local verification also passed 47 focused and 601 full tests, including a clean-worktree rerun. Three mutation probes were rejected before restoring the final source. All four remote blobs now match tested files; the intermediate snapshot description transcription error was corrected before this hosted run.

Required CI and CI Extended are not yet claimed complete; this is a review request, not approval. Keep draft while validation/review remains pending. R4 maintainer plus fresh-context review remains the merge gate; no auto-merge or rehearsal activation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T23:35:46.645290Z e4dba40 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cfa0eb481

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
@Chris0Jeky
Chris0Jeky marked this pull request as ready for review September 21, 2026 18:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cfa0eb481

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
@Chris0Jeky
Chris0Jeky force-pushed the codex/3170-runner-inventory-prerequisite branch 2 times, most recently from 1d75fe0 to 5dd2161 Compare September 21, 2026 20:15
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact current head 5dd2161 against base fb830ed. This is the one current-head review request after the main-base requalification. Focus on the PR's changed ownership and stale-settlement behavior, and report only merge-blocking correctness or security defects.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 5dd2161648

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review Please review the exact current head 77308c8, including the new parser fixes and tests. Treat prior review threads as already triaged; report only findings introduced or still present at this exact head.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77308c82ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review Please review the exact current head f7368d9. This adds YAML-property-aware keep-chomp preservation, a bounded reviewed-surface projection, matching regression tests, and the documented bound. Treat prior threads as addressed; report only merge-blocking correctness or security defects at this exact head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: f7368d90ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Chris0Jeky
Chris0Jeky force-pushed the codex/3170-runner-inventory-prerequisite branch from f7368d9 to ff5099d Compare September 21, 2026 22:05
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff5099db7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 277851c300

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci/smart-ci/workflow-runner-inventory.mjs Outdated
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00ebe3fb7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/analysis/2026-09-20-ci17-runner-inventory.md Outdated
@Chris0Jeky
Chris0Jeky force-pushed the codex/3170-runner-inventory-prerequisite branch from edcdbcd to e4dba40 Compare September 21, 2026 23:24
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: e4dba402fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Chris0Jeky
Chris0Jeky merged commit d7a146c into main Sep 22, 2026
36 checks passed
@Chris0Jeky
Chris0Jeky deleted the codex/3170-runner-inventory-prerequisite branch September 22, 2026 00:06
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CI-17: Add a fail-closed Linux-only private-cutover rehearsal across all workflows

1 participant