Repository navigation
Move the demo to SvelteKit 3 - #300
Merged
Merged
Conversation
SvelteKit 3 dropped svelte.config.js, so the adapter and preprocess options move into the sveltekit() Vite plugin. tsconfig.json now extends $app/tsconfig, which replaces the generated .svelte-kit/tsconfig.json.
# Conflicts: # examples/share-demo/pnpm-lock.yaml
# Conflicts: # examples/share-demo/pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit 3 drops
svelte.config.js: the adapter and preprocess options are passed to thesveltekit()Vite plugin instead, and the generated.svelte-kit/tsconfig.jsonthat the demo's tsconfig extended no longer exists (it extends$app/tsconfignow, which already carries the compiler options the file used to repeat).The demo keeps the same SPA setup (
fallback: index.html,ssr = false).pnpm buildandpnpm checkpass locally with no SvelteKit warnings. pnpm warns that kit 3 wants typescript ^6 while the demo pins ~5.6; the build and svelte-check are fine on 5.6, so that bump is left for its own change.Supersedes #299.