Restore python 3.6 and update CI to import module after installing - #178
Open
tynanford wants to merge 1 commit into
Open
Restore python 3.6 and update CI to import module after installing#178tynanford wants to merge 1 commit into
tynanford wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tynanford
force-pushed
the
master
branch
2 times, most recently
from
August 6, 2026 23:26
6d7fba5 to
50e818a
Compare
Comment on lines
+55
to
+58
| python -m pip install \ | ||
| "channelfinder @ https://github.com/ChannelFinder/pyCFClient/archive/refs/tags/v3.2.0.zip#sha256=ec89537f336c4cb8db18909c4b02176dd5fbd03f5872a6527129879cbf3f7c85" \ | ||
| "dataclasses==0.8; python_version<'3.7'" \ | ||
| "requests>=2.27.1,<2.28; python_version<'3.7'" \ |
|
anderslindho
requested changes
Aug 7, 2026
anderslindho
left a comment
anderslindho
left a comment
Contributor
There was a problem hiding this comment.
Unfortunately this doesn’t work as-is - note Successfully installed UNKNOWN-0.0.0 in the 3.6 build log.
We’ll have to reintroduce setup.cfg, move the [project] / package metadata out of pyproject.toml, pin setuptools to something that still runs on 3.6, and fix the smoke test: right now PYTHONPATH=. imports from the checkout even when install failed, so it can’t catch this. After a real pip install ., run the import from /tmp (or any dir outside server/) so it has to use the installed package. We should probably also set ruff to py37 (it doesn’t support 36).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#177
This updates processors.py and recast.py to work with python3.6 and above - updated type hints and remove removeprefix which is >=3.9
Had claude help with updating the CI. It now actually imports the package as @anderslindho mentioned and manually installs the pip packages for 3.6 since setuptools on 3.6 doesn't work with the pyproject.toml setup. Claude also found an issue with the pyproject.toml file: The <3.8 and <3.7 lines for requests and twisted overlap for python 3.6.