Resolve Sonar issues - #20
Merged
Merged
Conversation
Refs: c:S1117
Refs: c:S1117
Refs: c:S1659
`s->sd` and `s->wakeup` are different sockets with different lifetimes, and the two `sd[]` entries are opposite ends of a pair. Chaining the assignments made those look like one initialisation. Refs: c:S1121
Refs: cpp:S1110
An unquoted expansion is word-split by the shell. The `ARG` is overridable at build time. Refs: docker:S6570
The download stage installed `wget` and `git` with recommends on; the build stage already turns them off. `ca-certificates` has to be named explicitly afterwards: it only arrived as a `wget` recommendation, and the `https` fetch of Base fails certificate verification without it. Refs: docker:S6500
A moving tag such as `docker/build-push-action@v6` resolves to whatever the owner last pushed. This workflow holds `packages: write` and publishes the image that recceiver's integration tests pull, so pin the SHA and keep the version in a trailing comment. Actions under `actions/` stay on tags. Refs: githubactions:S7637
The rename and the build were separate `RUN` instructions, so one layer held nothing but a renamed directory, and the build entered the tree with `cd`. Refs: docker:S7031, docker:S6597
Keeping a separate `RUN` for the build creates a docker layer that only holds the one-line `configure/RELEASE.local` written on the previous row. Join the two so that file never becomes its own layer. Refs: docker:S7031
anderslindho
requested review from
jacomago,
ralphlange,
shroffk,
simon-ess and
tynanford
August 6, 2026 08:43
|
tynanford
approved these changes
Aug 6, 2026
tynanford
left a comment
tynanford
left a comment
Contributor
There was a problem hiding this comment.
The changes look fine to me. Only question is if the argument to casterThread being called junk was meaningful vs just calling it arg
static void casterThread(void* junk)
Contributor
Nope. Just an odd habit of mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits and sonar report for main/master vs this branch. Note that not all open issues have been addressed, as some are more complex or complicated, and some would go against EPICS conventions and/or needs.