Clean up monorepo path leftovers after the client/ split - #19
Merged
Conversation
This was a fragment of the recceiver integration stack and still points at ../client. Nothing here uses it; the maintained compose file is in recsync and pulls the published image.
Same fix RELEASE already got: the extra /../ was for the old client/ subdirectory, so parent CONFIG_SITE.local includes missed.
configure/*.local is gitignored on purpose. docker/RELEASE.local was a workaround that checked a machine-specific EPICS_BASE into the tree. Write configure/RELEASE.local during the image build instead, and use /reccaster rather than /recsync as the workdir.
shroffk
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few paths still assumed the old
recsync/clientlayout.ioc-compose.ymlstill hadbuild: ../clientand is unused here; the integration stack in recsync pulls the published image instead.configure/CONFIG_SITEstill searched one level too high for parentCONFIG_SITE.localoverrides (same mistakeRELEASEalready fixed).The Dockerfile used
/recsyncas the workdir and committeddocker/RELEASE.localto dodgeconfigure/*.localbeing gitignored. Writeconfigure/RELEASE.localat image build time from the containerEPICS_BASE, and use/reccasteras the workdir.Note: anyone mounting or scripting against
/recsyncinside the image needs to switch to/reccaster.