Skip to content

chore: remove FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS workaround in snapshot tests and update affected snapshots#7154

Draft
sudo-shashank wants to merge 6 commits into
mainfrom
shashank/fix-test-snapshots
Draft

chore: remove FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS workaround in snapshot tests and update affected snapshots#7154
sudo-shashank wants to merge 6 commits into
mainfrom
shashank/fix-test-snapshots

Conversation

@sudo-shashank

@sudo-shashank sudo-shashank commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #7118

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests

    • Expanded ETH GetBlockReceipts test coverage to include Safe and Finalized block states in addition to existing cases
    • Updated test snapshot artifacts for ETH and Filecoin RPC methods with newer recorded data
  • Refactor

    • Simplified state computation policy determination to rely exclusively on environment configuration settings

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 92404c15-178e-4f4a-af40-fbce60adf11c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-test-snapshots
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/fix-test-snapshots

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added the RPC requires calibnet RPC checks to run on CI label Jun 9, 2026
@sudo-shashank sudo-shashank marked this pull request as ready for review June 12, 2026 09:19
@sudo-shashank sudo-shashank requested a review from a team as a code owner June 12, 2026 09:19
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a team June 12, 2026 09:19
@sudo-shashank sudo-shashank marked this pull request as draft June 12, 2026 09:23
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.37%. Comparing base (cbdb13d) to head (488ce2a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/state_manager/state_computation.rs 77.15% <ø> (-1.19%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdb13d...488ce2a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove FOREST_ETH_RPC_COMPUTE_STATE_ON_INDEX_MISS workaround in snapshot tests and update affected snapshots

1 participant