Skip to content

fix: fix localStorage sync, revoke object URLs, static imports, xdr shadowing - #660

Merged
DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
davidjhonsonmate:fix/issues-490-491-492-493
Oct 20, 2026
Merged

DeFiVC merged 1 commit into
ChainLearnOfficial:mainfrom
davidjhonsonmate:fix/issues-490-491-492-493

Conversation

@davidjhonsonmate

Copy link
Copy Markdown
Contributor

Closes #490
Closes #491
Closes #492
Closes #493

Summary

localStorage Fix (Issue #493)

  • When another tab removes the localStorage item, the hook now resets to initialValue
  • Cross-tab sync works correctly for both updates and removals

AvatarUpload Fix (Issue #492)

  • URL.revokeObjectURL called when crop dialog closes
  • URL.revokeObjectURL called when a new image replaces the old one
  • URL.revokeObjectURL called on component unmount
  • Uses ref to track current object URL

Connect Page Fix (Issue #491)

  • Static imports for getProfile and useAuthStore
  • No more dynamic import() overhead on connection attempts

Transactions Fix (Issue #490)

  • Renamed xdr parameter to txXdr to avoid shadowing imported xdr module
  • Prevents future bugs from parameter shadowing

…hadowing

- use-local-storage.ts: handle null newValue (removal events) by resetting to initialValue (ChainLearnOfficial#493)
- avatar-upload.tsx: revoke object URL on cancel, new selection, and unmount (ChainLearnOfficial#492)
- connect/page.tsx: replace dynamic imports with static imports (ChainLearnOfficial#491)
- transactions.ts: rename xdr parameter to txXdr to avoid shadowing imported xdr module (ChainLearnOfficial#490)
@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@davidjhonsonmate Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for chainlearn failed.

Name Link
🔨 Latest commit 25ea992
🔍 Latest deploy log https://app.netlify.com/projects/chainlearn/deploys/6ad77f89c2490ad82a7a2239

@DeFiVC
DeFiVC merged commit 6972854 into ChainLearnOfficial:main Oct 20, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants