Repository navigation
fix: avatar stub, quiz refetch, dashboard error handling, cert XSS (#486-#489) - #659
Merged
Merged
Conversation
…hainLearnOfficial#486-ChainLearnOfficial#489) - ChainLearnOfficial#486: replace fake avatar upload success toast with clear 'coming soon' placeholder — no more misleading success on non-functional stub - ChainLearnOfficial#487: add refetch() to useQuiz hook with ref-based trigger so quiz page can reload without window.location.reload() - ChainLearnOfficial#488: wrap each dashboard tab in SectionErrorBoundary + section-specific error messages — one failing section no longer breaks the whole page - ChainLearnOfficial#489: escape all interpolated values in certificate HTML download to prevent XSS via malicious course titles or credential IDs
|
@pooramara Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for chainlearn failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
Closes #487
Closes #488
Closes #489
What changed
refetch()touseQuizhook with a ref-based trigger. Callingrefetchre-fetches the quiz from the API without a full page reload.SectionErrorBoundarywith section-specific error messages. A failure in rewards no longer prevents courses or credentials from displaying.htmlEscapeand applied it to all interpolated values in the certificate HTML download — prevents XSS via malicious course titles or credential IDs.How to test
const { refetch } = useQuiz(id)→ callrefetch()→ quiz reloads without page flash.<script>alert(1)</script>→ download certificate → script does not execute.