Repository navigation
fix: validation dedup, secure cookie, quiz refetch, xdr shadowing - #658
Merged
DeFiVC merged 2 commits intoOct 20, 2026
Conversation
Fixes ChainLearnOfficial#482, Fixes ChainLearnOfficial#483, Fixes ChainLearnOfficial#484, Fixes ChainLearnOfficial#485 Issue ChainLearnOfficial#485 — xdr parameter shadowing in contracts.ts: - Renamed xdr parameter to txXdr in claimRewardOnChain and mintCredentialOnChain - Prevents silent shadowing of stellar-sdk xdr module Issue ChainLearnOfficial#483 — Session cookie Secure flag: - Added Secure flag to chainlearn-session cookie - Prevents token transmission over HTTP Issue ChainLearnOfficial#484 — Quiz page state-based refresh: - Added refetch callback to useQuiz hook - Eliminates need for window.location.reload() Issue ChainLearnOfficial#482 — Onboarding validation deduplication: - Created shared validation.ts with validateDisplayName - Updated onboarding page to use shared validator - Removes inline validation checks
❌ Deploy Preview for chainlearn failed.
|
|
@nonsobethel0-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482, Fixes #483, Fixes #484, Fixes #485
What changed
Issue #485 — xdr parameter shadowing
xdrparameter totxXdrinclaimRewardOnChainandmintCredentialOnChainxdrmodule importIssue #483 — Session cookie Secure flag
Secureflag tochainlearn-sessioncookie inauth-store.tsIssue #484 — Quiz page state-based refresh
refetchcallback touseQuizhookIssue #482 — Onboarding validation deduplication
src/lib/utils/validation.tswithvalidateDisplayNameFiles changed
src/lib/stellar/contracts.ts— renamed shadowed parametersrc/store/auth-store.ts— added Secure cookie flagsrc/lib/hooks/use-quiz.ts— added refetch callbacksrc/lib/utils/validation.ts— new shared validation utilitysrc/app/(auth)/onboarding/page.tsx— use shared validatorHow to test
claimRewardOnChain— noxdrshadowingSecureflag present on HTTPSrefetch()on useQuiz — data refreshes without reload