Repository navigation
Fix issues #493, #494, #495, #497 - #664
Merged
DeFiVC merged 1 commit intoOct 20, 2026
Merged
Conversation
…Official#495, ChainLearnOfficial#497 Closes ChainLearnOfficial#493: Remove redundant test_contract_upgrade that never actually calls upgrade() Closes ChainLearnOfficial#494: Replace trivial gas benchmark assertions with meaningful regression thresholds Closes ChainLearnOfficial#495: Add negative authorization tests for progress-tracker and credential-nft admin functions Closes ChainLearnOfficial#497: Add pause check to batch_claim_reward and add regression tests
|
@MarcusDavidG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes four issues assigned to me:
Issue #493: test_contract_upgrade never actually calls upgrade()
Issue #494: Gas benchmark assertions are trivially true (assert!(cost > 0))
Issue #495: No authorization tests for progress-tracker and credential-nft admin functions
Issue #497: batch_claim_reward bypasses pause check while claim_reward checks it
Testing
All changes are test-only or minimal code additions with corresponding tests. No builds or package installations were run as per instructions.
Closes #493
closes #494
closes #495
closes #497