Repository navigation
Add burn_from unit tests to learn-token #522
Description
Severity: medium
Labels: tests, rust, Stellar Wave
What
Write unit tests for the burn_from function in learn-token, covering successful burn via allowance, insufficient allowance rejection, burn from zero balance, and burn with expired allowance.
Why
burn_from has zero test coverage. It is a public SEP-41 function that spends another address's allowance to burn tokens. Without tests, regressions in allowance deduction or supply tracking could go undetected.
Scope
- Test
burn_fromwith valid allowance reduces balance, total_supply, and allowance - Test
burn_fromwith insufficient allowance panics - Test
burn_fromfrom zero balance panics - Test
burn_fromwith expired allowance panics - Test
burn_fromemitsburn_fromevent with correct topics
Out of scope
Testing the burn event itself (already covered), testing burn (separate function).
Acceptance criteria
- All 5 test cases pass
- Tests use
#[should_panic(expected = "...")] with specific error messages, not bare#[should_panic]` - Tests verify state changes (balance, supply, allowance) and event emission
Technical context
contracts/learn-token/src/lib.rs lines ~540-580 contain the burn_from implementation. The function deducts from the spender's allowance, burns from the owner's balance, and decrements total_supply.
Activity
cindybby18 commentedon Oct 19, 2026
@cindybby18 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @cindybby18 to this issue.
OlolaJaco commentedon Oct 19, 2026
@OlolaJaco has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @OlolaJaco to this issue.
drips-wave commentedon Oct 19, 2026
Congratulations, @OlolaJaco! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @OlolaJaco: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 19, 2026
🎉 This issue has been marked as completed on GrantFox!
@OlolaJaco's PR #660 was approved and merged by @DeFiVC.
🏆 @OlolaJaco: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (471 total points). Track your full progress on GrantFox.
👏 Great work, @OlolaJaco! Keep contributing to ChainLearnOfficial.
drips-wave commentedon Oct 19, 2026
This issue has been completed by @OlolaJaco as part of the Stellar Wave Program's 10th Wave 🥳
😎 @OlolaJaco: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.