Repository navigation
Fix: runs/{term_id}/ must use underscore form, not CURIE, in paths - #9
Merged
Merged
Conversation
Found via a real CI run (obophenotype/cell-ontology#3765): the colon-form term_id directory (runs/CL:0000037/) made actions/upload-artifact fail outright -- "The path for one of the files in artifact is not valid: /CL:0000037/report.md. Contains the following character: Colon :" #8's cell_id->term_id cleanup reasoned that a colon is a valid POSIX filename character, which is true, but missed that actions/upload-artifact enforces its own stricter path validation (cross-platform/NTFS compatibility) independent of the runner's actual filesystem. Keeps the single term_id field/concept from #8 (no reintroduction of a separate cell_id field) -- only the path construction now calls for the underscore substitution, same as the pre-#8 cell_id convention used for, while the term_id field inside written JSON/markdown content stays in CURIE form. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ubyndr
added a commit
to obophenotype/uberon
that referenced
this pull request
Oct 1, 2026
Cellular-Semantics/clara_workflow#9 merged: fixes runs/{term_id}/ using the CURIE form (colon) in artifact paths, which made actions/upload-artifact fail outright and silently skipped the summary-comment steps on every real run that reached stage 2/3 (confirmed via cell-ontology's PR #3765). Signed-off-by: @ai4c-agent Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ubyndr
added a commit
to obophenotype/cell-ontology
that referenced
this pull request
Oct 1, 2026
Cellular-Semantics/clara_workflow#9 merged: fixes runs/{term_id}/ using the CURIE form (colon) in artifact paths, which made actions/upload-artifact fail outright and silently skipped the summary-comment steps on every real run that reached stage 2/3. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via a real CI run (obophenotype/cell-ontology#3765): the colon-form
term_iddirectory (runs/CL:0000037/) madeactions/upload-artifactfail outright —```
The path for one of the files in artifact is not valid: /CL:0000037/report.md. Contains the following character: Colon :
```
#8's
cell_id->term_idcleanup reasoned that a colon is a valid POSIX filename character, which is true, but missed thatactions/upload-artifactenforces its own stricter path validation (cross-platform/NTFS compatibility) independent of the runner's actual filesystem.Keeps the single
term_idfield/concept from #8 (no reintroduction of a separatecell_idfield) — only the path construction now calls for the underscore substitution, same as the pre-#8cell_idconvention, while theterm_idfield inside written JSON/markdown content stays in CURIE form.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com