Correct the frame-list type on the pipeline runner's node input - #44
Merged
Merged
Conversation
_node_input is annotated Tuple[List[float], bool], but it returns a list of frames, not a list of floats: the no-incoming-edge branch returns frames_from(), which is List[Any], and the other branch wraps a single extracted vector as [frame]. mypy caught the mismatch and the lint job has been failing on main since 60763a2. Only the annotation was wrong. The runtime shape is correct and unchanged -- ServingService.predict consumes a list of frames, and a single-node graph run returns a prediction end to end. Verified: mypy clean across all 413 source files, ruff clean, and the four pipeline test files pass (33 passed).
w4ffl35
added a commit
that referenced
this pull request
Sep 16, 2026
_node_input is annotated Tuple[List[float], bool], but it returns a list of frames, not a list of floats: the no-incoming-edge branch returns frames_from(), which is List[Any], and the other branch wraps a single extracted vector as [frame]. mypy caught the mismatch and the lint job has been failing on main since da88b88. Only the annotation was wrong. The runtime shape is correct and unchanged -- ServingService.predict consumes a list of frames, and a single-node graph run returns a prediction end to end. Verified: mypy clean across all 413 source files, ruff clean, and the four pipeline test files pass (33 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_node_inputis annotatedTuple[List[float], bool]but returns a list of frames, not a list of floats. The no-incoming-edge branch returnsframes_from()(List[Any]); the other wraps one extracted vector as[frame].This has been failing
lintonmainsince 60763a2 — it is not introduced by any open PR.Only the annotation changes. The runtime shape is correct and unchanged:
ServingService.predictconsumes a list of frames, and a single-node graph run returns a prediction end to end.Verified
mypyclean across all 413 source files (the exact job CI runs)ruff check .cleantests/test_pipeline_runner.py,test_pipeline_graph.py,test_pipeline_store.py,test_server_pipeline_actions.py— 33 passedNo human review or manual testing was performed.