Repository navigation
feat(desktop-gpui): draw on screen while recording - #4314
Open
richiemcilroy wants to merge 13 commits into
Open
richiemcilroy wants to merge 13 commits into
richiemcilroy wants to merge 13 commits into
Conversation
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · 1 credit · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Draw on screen while recording. Pen, highlighter, arrow and rectangle in five colours, with undo and clear all, toggled from a new pen button on the recording bar or ⌃⌘P. Strokes are captured in the recording; the tools never are. Strokes fade a few seconds after they're drawn unless "Keep drawings on screen" is on in Settings > General.
Left, the screen while drawing. Right, the same moment in the recording: every stroke, no tools.
hotkeys.rs,RecordingScopes).Proof (real app on a Mac mini, driven with posted mouse and key events; synthetic page)
display.mp4: mid-stroke, every stroke (above, right), after Clear all. Instantoutput.mp4: arrow.Drawing numbers use the dev profile with the app crate at opt-level 2 (dependencies already are); the plain debug build reads about 20%.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Adds drawing tools for macOS display and area recordings, with fading strokes, undo, clear, and a recording-only shortcut.
Reviews (2) · Last reviewed commit: "chore(desktop-gpui): drop comments that ..." · Reviewed by Greptile