Repository navigation
ci(verify): let the Windows real-capture job finish the full suite - #4310
Draft
richiemcilroy wants to merge 1 commit into
Draft
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
Verify recording (real capture)run never finishes on Windows. Thereal-capture (windows-2022)job has been cancelled at its 60-minute limit on every scheduled run from 2026-11-09 to 2026-11-16 (8 of 8), so the cases after the cutoff, includingrecording/studio-camera/longandrecording/instant/long-holds, never run on Windows and the nightly verdict is red for a reason that is not a recording fault.Measurement
The FULL tier with 3 repeats, run on a scratch branch whose only change was a longer limit (run 43988909726,
mainat d54af01):test result: ok. 13 passed; 0 failed).studio-screen/mp4-holdsis about 414 s per repeat (a 30 s recording; stop and remux under 0.1 s),studio-camera/long268 s, the otherstudio-screencases about 115 s. Instant cases take about 16 s per repeat.Change
real-capture-windowsgetstimeout-minutes: 90, about 27% above the measured run. Nothing else changes: same cases, same repeats, same checks.Not done
studio-camera/*Windows xfail text still describes the frame pacer fixed on 2026-10-17. The current Windows result is a different start-up offset; that belongs in its own change.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Raises the Windows real-capture job limit from 60 to 90 minutes so the measured nightly suite can finish.
Reviews (1) · Last reviewed commit: "ci(verify): let the Windows real-capture..." · Reviewed by Greptile