Repository navigation
feat(web): share page brand colour, custom thumbnails and embed options - #4307
Open
richiemcilroy wants to merge 13 commits into
Open
richiemcilroy wants to merge 13 commits into
richiemcilroy wants to merge 13 commits into
Conversation
# Conflicts: # apps/web/app/embed/[videoId]/page.tsx # apps/web/app/s/[videoId]/_components/call-to-action/CallToActionDialog.tsx
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · 10 credits · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Organizations can set a brand colour for share pages and embeds, owners can give any video a custom thumbnail (upload an image or pick a frame), and the embed tab gains toggles for title, owner, logo and autoplay.
Brand colour
Org settings, Shareable links. Pro, owners and admins. It colours the play button, progress bar and player focus rings on share pages and embeds, and is offered first in the call to action colour presets. It is opt-in, so orgs that already set desktop brand colours see no change until they pick one; those colours show up as swatches. The play icon switches between white and ink for contrast, and colours too dark to see on video keep the progress bar and rings white. It is server rendered, so Cap blue never flashes first.
Custom thumbnail
"Thumbnail" in the share page Manage menu and the dashboard card menu. Pick a frame (taken server side with ffmpeg from the published MP4) or upload a PNG, JPEG or WebP (resized to 1920 px JPEG in the browser). Used by the dashboard, share and embed posters, OG image, oEmbed and Slack unfurls. The OG URL gains
&v=so link previews refresh straight away. Reset to automatic removes it. Stored under the video's own prefix, so delete and duplicate carry it along. No schema change.Embed options
URL params
title=false,owner=false,branding=false(Pro),autoplay=true&muted=true, plus the existingt. Default embed code is byte-identical to before. I left out hiding controls, since a Cap embed without controls can't be paused or unmuted by keyboard or screen reader users.Proof


Confidence Score: 5/5
The changes since the previous review appear safe to merge.Summary
Adds organization brand colours, custom video thumbnails, and embed options.
Reviews (2) · Last reviewed commit: "chore(web): drop comments that restate t..." · Reviewed by Greptile