Repository navigation
fix(desktop-gpui): show no expiry date for lifetime licenses - #4302
Open
richiemcilroy wants to merge 5 commits into
Open
richiemcilroy wants to merge 5 commits into
richiemcilroy wants to merge 5 commits into
Conversation
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Lifetime desktop licenses showed "Expires 1/19/2038" in Settings > Plan & license. They now show no expiry; yearly licenses keep their date.
Root cause
nextRenewalDate = new Date("2038-01-19 03:14:07")(the 32-bittime_tlimit, parsed in the server's time zone) and/commercial/activatereturns it asexpiryDate.render_license_active(apps/desktop-gpui/src/settings_pages.rs) formatted anyexpiryDateit got, so lifetime keys read as expiring in 2038. The Tauri app did the same.Change
license_expiry_labelreturnsNonewithin a day of the sentinel (covers every server time zone offset), so the existing "Expires" block is not rendered. Everything else formats exactly as before (%-m/%-d/%Y).expiryDate.render_license_active.expiry_dateis still stored unchanged in the store (general_settings.commercialLicense), so Tauri 0.6.0 and GPUI 0.6.1 to 0.6.3 stores keep working.Tests
lifetime_license_has_no_expiry_label: the sentinel in UTC, UTC-8 and UTC+14.yearly_license_keeps_its_expiry_label:None, a 2027 date, and a date three days before the sentinel all keep their label.Proof
expiryDate2027-11-16)cap-gpuisuiteOnly test keys and a local isolated store were used.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Hides the expiry row for lifetime desktop licenses without changing saved license data.
Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile