Repository navigation
fix(desktop): prevent text overflow in export options and statistics (#4274) - #4293
Open
TassioSales wants to merge 2 commits into
Open
TassioSales wants to merge 2 commits into
TassioSales wants to merge 2 commits into
Conversation
Contributor
|
@TassioSales is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4274 (CAP-1024) by resolving layout and text overflow issues across the export options and statistics:
.flex_1().min_w_0()to the warning text container so the description wraps properly within the sidebar card.540px, relaxed inner column padding from16pxto12px, and added.truncate()to stat values so metrics like1660×1080 · 30 fpsfit comfortably without overflowing across column dividers.destination.linkfrom"Shareable Link"to"Link", matching"File"and"Clipboard"and eliminating truncation in the 3-item segmented control.Changes
apps/desktop-gpui/src/editor_export.rs: Applied flex wrapping to cursor warning and spacing/truncation guards to stats.apps/desktop-gpui/locales/en.toml: Updated[editor.export.destination] linklabel to"Link".

Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes text overflow on the desktop export page.
No actionable issues found. Visual capture was not performed because this page requires the native desktop app and an open editor session.
Reviews (1) · Last reviewed commit: "fix(desktop): prevent text overflow in e..." · Reviewed by Greptile