Repository navigation
feat(desktop-gpui): choose the diagnostic test duration in Settings > Feedback - #4253
Open
richiemcilroy wants to merge 6 commits into
Open
richiemcilroy wants to merge 6 commits into
richiemcilroy wants to merge 6 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
richiemcilroy
marked this pull request as ready for review
November 14, 2026 05:25
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · 1 credit · Review details |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brings back 0.6.0's "Test duration" choice (20, 40 or 60 seconds) for the diagnostic report in Settings > Feedback. The GPUI app always ran 20 seconds.
Root cause
DIAGNOSTIC_DURATIONS(20 / 40 / 60 s) and passed the choice to the run and its confirmation (settings/feedback.tsx:58-61,:131,:143,:161).diagnostics::DEFAULT_DURATION_SECS(20) in both the confirmation text andSyncTestOptions, so there was no way to run a longer, more drift-sensitive test.What changed
ui::SegmentedControl::settingsas the mode row. It is disabled while a run is going, like the other options.createSignal(20)did; nothing new is stored.duration_label,duration_descriptionandduration_optionin all seven locales.Callers checked
diagnostics::DEFAULT_DURATION_SECS: still the first choice and the default; its other uses are unchanged.confirm_bodyandSyncTestOptionsinsettings_pages.rs: the only two places the run's length was read; both now use the chosen value.What could regress
Tests
every_offered_duration_reaches_the_cli_unclamped(diagnostics.rs): each choice lands in--durationas given and sits inside the CLI's clamps; the first choice is the default.settings_surface_tests.rs: the new label, description and each option render the English strings, andduration_optionis in the locale key list.Proof
Real app built from this branch and from main, Linux under Xvfb, driven with xdotool: Settings > Feedback, pick 60 seconds, press Run Diagnostic, read the confirmation, cancel. (The run itself cannot start here: screen capture is unavailable under Xvfb.)
Recordings: this PR (light, dark), main (light, dark).


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues remain.Summary
Adds 20-, 40- and 60-second diagnostic choices in Settings > Feedback.
The comment identified in the previous, unnumbered thread has been removed. No new actionable issues were found. Review checks were source-only; no build, tests or native UI capture were run.
Reviews (5) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile