Repository navigation
fix(recording): stop and save a macOS recording when its capture source goes away #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+389
−42
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0e6ae12
fix(recording): stop and save a macOS recording when its capture sour…
richiemcilroy 8968dad
style: rustfmt
richiemcilroy fc2cf30
test(recording): give the macOS stop-order fixture the stopping flag
richiemcilroy 1eb8fe3
test(recording): model the actor's completion sender in the macOS wat…
richiemcilroy 6ac82b7
test(desktop-gpui): run the capture source test on every platform
richiemcilroy 5bd3197
fix(desktop-gpui): only say a lost-source recording was saved when St…
richiemcilroy 35ffc39
test(desktop-gpui): real-app check that closing the recorded window s…
richiemcilroy 24c34e8
Merge remote-tracking branch 'origin/main' into fix/macos-capture-tar…
richiemcilroy e33c583
test(desktop-gpui): record a TextEdit window and quit TextEdit in the…
richiemcilroy b3e3fbc
fix(recording): stop and save a macOS window recording when its windo…
richiemcilroy 3e1e1f3
test(desktop-gpui): record the closing window as a focused-window cap…
richiemcilroy 9f5a6b7
test(desktop-gpui): close only the test's TextEdit document instead o…
richiemcilroy 1277bf9
Merge remote-tracking branch 'origin/main' into fix/macos-capture-tar…
richiemcilroy 2a48b76
test(desktop-gpui): end the test's own TextEdit instance instead of s…
richiemcilroy 67e3cd3
Merge remote-tracking branch 'origin/main' into fix/macos-capture-tar…
richiemcilroy 33e4fb4
fix(recording): only watch for a closed window when the stream record…
richiemcilroy 09bbfed
Merge remote-tracking branch 'origin/main' into HEAD
richiemcilroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.