Repository navigation
fix(desktop-gpui): anchor the mode picker capsule to its own width + new menu item - #3483
Open
ItsEeleeya wants to merge 10 commits into
Open
ItsEeleeya wants to merge 10 commits into
ItsEeleeya wants to merge 10 commits into
Conversation
Contributor
|
@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks! Can you get Greptile to 5/5? Then we'll take a look. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
It should be already, maybe have it review again? |
Member
|
Thanks! Can you get Greptile to 5/5 on the latest commit? Then we'll take a look. |
Contributor
Author
Could you re-trigger Greptile?
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one issue and adds a new menu item.
macOS Mode picker
the capsule was positioned from the view's live width, so when the menu was wider than the picker (depending on the language), it shifted after a rebuild. It is now anchored to the picker's own width.
New menu item:
File > Export… (⇧⌘E): adds the item to the File menu. It is enabled only when an editor window is focused. In the video editor it opens the export page, the same as the Export button. In the screenshot editor it runs the same file export as Save.
The screenshot export action should respect the open crop dialog before this PR merges.
Findings
Fix with agent prompt
Summary
Anchors the macOS mode picker capsule to the picker's own width and adds File > Export… with translations and menu tests.
Checks were source-based. No runtime or visual verification was performed; the changed native macOS UI cannot run in this Linux environment.
Reviews (1) · Last reviewed commit: "feat(desktop-gpui): add File > Export… (..." · Reviewed by Greptile