Skip to content

fix(desktop-gpui): anchor the mode picker capsule to its own width + new menu item - #3483

Open
ItsEeleeya wants to merge 10 commits into
CapSoftware:mainfrom
ItsEeleeya:mode_picker_fix
Open

ItsEeleeya wants to merge 10 commits into
CapSoftware:mainfrom
ItsEeleeya:mode_picker_fix

Conversation

@ItsEeleeya

@ItsEeleeya ItsEeleeya commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes one issue and adds a new menu item.

macOS Mode picker

the capsule was positioned from the view's live width, so when the menu was wider than the picker (depending on the language), it shifted after a rebuild. It is now anchored to the picker's own width.

New menu item:

File > Export… (⇧⌘E): adds the item to the File menu. It is enabled only when an editor window is focused. In the video editor it opens the export page, the same as the Export button. In the screenshot editor it runs the same file export as Save.

RetriggerView in GreptileConfidence Score: 4/5

The screenshot export action should respect the open crop dialog before this PR merges.

Findings

  1. P1 Export skips the pending crop ▶
Fix with agent prompt
### Issue 1
apps/desktop-gpui/src/screenshot_editor.rs:4449-4453
Choosing File > Export… while the screenshot crop dialog is open calls `export_image`, which copies `self.project`. The dialog does not write its pending crop into that project until the user clicks Save, so the exported image uses the previous crop instead of the one shown in the dialog. Block this action while `self.crop.is_some()`, matching the existing save shortcut.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Anchors the macOS mode picker capsule to the picker's own width and adds File > Export… with translations and menu tests.

  • File > Export… uses the focused editor’s existing export flow.
  • The macOS mode-picker capsule stays anchored to the picker’s own width.

Checks were source-based. No runtime or visual verification was performed; the changed native macOS UI cannot run in this Linux environment.

Reviews (1) · Last reviewed commit: "feat(desktop-gpui): add File > Export… (..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy

Copy link
Copy Markdown
Member

Thanks! Can you get Greptile to 5/5? Then we'll take a look.

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
cap-status Skipped Skipped Nov 17, 2026 1:54am UTC

@vercel
vercel Bot temporarily deployed to Preview – cap-status November 3, 2026 14:21 Inactive
@ItsEeleeya

Copy link
Copy Markdown
Contributor Author

Thanks! Can you get Greptile to 5/5? Then we'll take a look.

It should be already, maybe have it review again?
File > Export… gets disabled now when the screenshot editor has the cropper open.

@richiemcilroy

Copy link
Copy Markdown
Member

Thanks! Can you get Greptile to 5/5 on the latest commit? Then we'll take a look.

@vercel
vercel Bot temporarily deployed to Preview – cap-status November 4, 2026 18:52 Inactive
@ItsEeleeya

Copy link
Copy Markdown
Contributor Author

Thanks! Can you get Greptile to 5/5 on the latest commit? Then we'll take a look.

Could you re-trigger Greptile?
The previous issue was already fixed.
New changes since:

  • We ensure the screenshot editor is in focus so the menu items can update properly.
  • Mode picker now animates press and has a larger hit area that is 36pt tall, recommended by AppKit for Touch capable screens.

@vercel
vercel Bot temporarily deployed to Preview – cap-status November 7, 2026 05:20 Inactive
@vercel
vercel Bot temporarily deployed to Preview – cap-status November 17, 2026 01:54 Inactive

This branch was previously deployed

1 inactive deployment
Preview – cap-status — e6906818 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants