-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: bring the desktop editor to web #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richiemcilroy
wants to merge
30
commits into
main
Choose a base branch
from
feature/web-editor-desktop-parity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43,062
−2,060
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
748bac3
feat: bring desktop editor to web
richiemcilroy a6e1dd5
fix: isolate editor worker from standalone media server
richiemcilroy b13e7f3
fix: reclaim unattached web editor sessions
richiemcilroy aece09d
chore: pin editor worker build inputs
richiemcilroy f6ec320
fix: align GPUI icon inventory with caption controls
richiemcilroy c067e9a
fix: normalize web recorder warning quotes
richiemcilroy 86ec71f
fix: gate macOS-only memory pressure variants
richiemcilroy fac71b4
improve: show desktop editor while web sessions prepare
richiemcilroy 2943fc6
fix: verify staged editor assets before reuse
richiemcilroy 489510d
fix: require HTTPS for remote editor workers
richiemcilroy c6dcac6
fix: restore image overlays in web editor
richiemcilroy 1787aba
test: verify web image overlays in browsers
richiemcilroy 5a641d3
fix: restore self-host MinIO image pulls
richiemcilroy 3a6cae2
fix: pin self-host MinIO image digests
richiemcilroy f7e39b5
fix: format extension shortcut script
richiemcilroy bc148b4
improve: match desktop editor error state on web
richiemcilroy 39dafcb
fix: keep editor preparation visible during slow startup
richiemcilroy 6d41f66
fix: keep web editor recovery actions usable
richiemcilroy c6ad26b
fix: use browser-valid preview socket close code
richiemcilroy 640dab0
fix: clarify web recording bundle action
richiemcilroy 1f9a917
docs: explain separate webcam capture in web
richiemcilroy 36a536c
fix: align paired recordings to start calls
richiemcilroy 45820dc
fix: keep background editor exports alive
richiemcilroy 8359544
fix: retain active and completed editor exports
richiemcilroy 408cd52
fix: isolate extension tab-capture test gesture
richiemcilroy 7c500d7
fix: authenticate the native web editor renderer
richiemcilroy ec42b7a
fix: keep native H.264 benchmark authenticated
richiemcilroy 5c04675
fix: recover non-caption edits after plan downgrade
richiemcilroy 6397e5e
fix: bound web recorder backup memory
richiemcilroy 18eaba9
fix: preserve overflow during recorder spool recovery
richiemcilroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| name: Docker Build Editor Worker | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "apps/media-server/**" | ||
| - "apps/web/lib/editor-caption-access.ts" | ||
| - "apps/web/lib/editor-caption-transport.ts" | ||
| - "apps/web/lib/editor-recording-title.ts" | ||
| - "apps/desktop/src/assets/music/**" | ||
| - "apps/desktop/src-tauri/assets/backgrounds/**" | ||
| - "crates/**" | ||
| - "packages/editor-cap-bundle/**" | ||
| - "vendor/**" | ||
| - "Cargo.toml" | ||
| - "Cargo.lock" | ||
| - "package.json" | ||
| - "bun.lock" | ||
| - "bunfig.toml" | ||
| - ".github/workflows/docker-build-editor-worker.yml" | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "apps/media-server/**" | ||
| - "apps/web/lib/editor-caption-access.ts" | ||
| - "apps/web/lib/editor-caption-transport.ts" | ||
| - "apps/web/lib/editor-recording-title.ts" | ||
| - "apps/desktop/src/assets/music/**" | ||
| - "apps/desktop/src-tauri/assets/backgrounds/**" | ||
| - "crates/**" | ||
| - "packages/editor-cap-bundle/**" | ||
| - "vendor/**" | ||
| - "Cargo.toml" | ||
| - "Cargo.lock" | ||
| - "package.json" | ||
| - "bun.lock" | ||
| - "bunfig.toml" | ||
| - ".github/workflows/docker-build-editor-worker.yml" | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build and test editor worker (${{ matrix.platform }}) | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - platform: amd64 | ||
| runner: ubuntu-24.04 | ||
| - platform: arm64 | ||
| runner: ubuntu-24.04-arm | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Set up Docker Buildx v3.12.0 | ||
| uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f | ||
| - name: Build editor worker image with Docker v6.19.2 | ||
| uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 | ||
| with: | ||
| context: . | ||
| file: apps/media-server/Dockerfile.editor | ||
| platforms: linux/${{ matrix.platform }} | ||
| load: true | ||
| tags: cap-editor-worker:verification | ||
| cache-from: type=gha,scope=editor-worker-${{ matrix.platform }} | ||
| cache-to: type=gha,mode=max,scope=editor-worker-${{ matrix.platform }} | ||
| - name: Check native worker readiness | ||
| run: | | ||
| docker run --rm --network none \ | ||
| -e CAP_WEB_EDITOR_PUBLIC_ORIGIN=http://127.0.0.1:3457 \ | ||
| -e MEDIA_SERVER_WEBHOOK_SECRET=test \ | ||
| --entrypoint bun cap-editor-worker:verification \ | ||
| -e 'import app from "./src/editor-worker-app.ts"; const response = await app.request("/health"); if (!response.ok) process.exit(1)' | ||
| - name: Exercise paired native editor routes | ||
| run: | | ||
| docker run --rm --network none --cpus 4 --memory 4g \ | ||
| -e MEDIA_SERVER_WEBHOOK_SECRET=test \ | ||
| --entrypoint bun cap-editor-worker:verification test \ | ||
| src/__tests__/editor-worker-app.test.ts \ | ||
| src/__tests__/lib/editor-assets.test.ts \ | ||
| src/__tests__/lib/editor-clip-thumbnails.test.ts \ | ||
| src/__tests__/lib/editor-config-paths.test.ts \ | ||
| src/__tests__/lib/editor-image-assets.test.ts \ | ||
| src/__tests__/lib/editor-wallpapers.test.ts \ | ||
| src/__tests__/routes/editor-clips.test.ts \ | ||
| src/__tests__/routes/editor.test.ts | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.