feat: add organization private sharing default and viewer invites - #2306
Open
richiemcilroy wants to merge 2 commits into
Open
richiemcilroy wants to merge 2 commits into
richiemcilroy wants to merge 2 commits into
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An organization can need new recordings to start Private while still inviting external viewers by email. The existing link sharing default remains in place until an owner or admin selects Private.
What changed
Verification
git diff --checkpassed. Biome reports existing warnings in untouchedVideosRepo.tslines.maincompleted without conflicts.Deployment note
Apply generated migration 0046 before deploying code that reads the new schema. UI runtime was not exercised in a browser because the repository prohibits starting another dev server.
Related: #2140 covers an older, overlapping organization default sharing proposal.
The PR appears safe to merge, with no actionable new issue found in the changes since the previous review.
Summary
This PR adds organization-level default visibility for new recordings and email-based viewer grants for private recordings.
Reviews (2) · Last reviewed commit: "fix: register recording viewer invitatio..."