fix(cli): resolve merge conflicts for PR #2932 - #2944
Conversation
Closes the two follow-ups #2885 flagged but left open: - `findSavedKey` now throws a `CliUserError` (which `shouldCapturePosthogException` already skips) instead of a bare `Error`, and drops the interpolated package-manager runner so one "not logged in" condition renders as one value. - The exception fingerprint no longer includes the top stack frame's function/filename. Bundles are minified, so that symbol changes per build and per call site, splitting one bug into a fresh issue every occurrence. It now keys only on the stable command path, error kind, error name and exit status. Generated-By: PostHog Code Task-Id: 88765fab-4def-4a9f-bf9c-52c6cc144a2b
Keep both CliUserError skip assertions: the not-logged-in findSavedKey message from this PR and the interactive-cancel messages from #2941. Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Keep main's install-path fingerprint comments and both CliUserError skip assertions (not-logged-in from this PR, duplicate-version from #2934). Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
2 participants
Summary (AI generated)
maininto fix(cli): stop error tracking minting a new issue per "not logged in" #2932 after fix(cli): stop error-tracking noise from duplicate-version uploads #2934 landed and resolved conflicts incli/src/posthog.tsandcli/test/test-posthog-exception.mjs.CliUserErrorskip assertions: not-logged-in from fix(cli): stop error tracking minting a new issue per "not logged in" #2932 and duplicate-version from fix(cli): stop error-tracking noise from duplicate-version uploads #2934.Motivation (AI generated)
PR #2932 conflicted again with
mainafter the overlapping PostHog fingerprint / expected-upload-abort work in #2934.Business Impact (AI generated)
Unblocks shipping the CLI error-tracking noise fix so "not logged in" no longer mints a new issue per occurrence.
Test Plan (AI generated)
bun test/test-posthog-exception.mjspassesMERGEABLEGenerated with AI
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.