Separate Config/Constants from Business Logic in authController - #1035
Merged
Conversation
…dmap Integrated ai powered project roadmap
…-64423 fix: code quality and safety improvements
…-37396 fix: code quality and safety improvements
…ats-checker feat: enhance AI Resume Analyzer with ATS compatibility insights
…ral-interview-coach feat: implement AI Behavioral Interview Coach
…n-calendar feat: add personalized interview preparation calendar
…uestion-collections feat: add interview question bookmark collections page
…preparation-certificates feat: add interview preparation achievement certificates page
…-53839 fix: code quality and safety improvements
…-15942 fix: code quality and safety improvements
…readiness-score-predictor feat: add interview readiness score predictor dashboard
…ession-timer feat: add AI study session timer with focus analytics
…goal-tracker feat: add interview preparation goal tracker
…n-difficulty-estimator feat: add AI interview question difficulty estimator
Fix: process is undefined in Vite configuration
…milestone-timeline feat: add AI interview preparation milestone timeline
…notes-organizer feat: add interview notes organizer with rich text support
Fix: React Fast Refresh broken in context files
Fix: Missing useEffect dependencies in authentication and state files
…preparation-summary feat: add AI weekly preparation summary
…deadline-countdown-widget feat: add interview deadline countdown widget
…resource-recommendation-engine feat: add interview resource recommendation engine
…n-achievement-showcase feat: add preparation achievement badges showcase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1000
Description
This pull request extracts the hardcoded constants and configuration (e.g., token expiries, regex patterns, cookie options) from \�uthController.js\ into a dedicated \�uthConfig.js\ file. This improves maintainability and separates configuration concerns from core authentication business logic.