Skip to content

Codex/hardened binary baseline - #7

Merged
Calvindd2f merged 7 commits into
masterfrom
codex/hardened-binary-baseline
Apr 16, 2026
Merged

Calvindd2f merged 7 commits into
masterfrom
codex/hardened-binary-baseline

Conversation

@Calvindd2f

Copy link
Copy Markdown
Owner

No description provided.

@Calvindd2f Calvindd2f self-assigned this Apr 16, 2026
@Calvindd2f Calvindd2f added the enhancement New feature or request label Apr 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions OfficeScrubC2R to a hardened binary PowerShell module architecture (v3.0.0), replacing legacy scripts with C# SDK-style projects. It introduces three primary cmdlets—Get-InstalledOfficeProducts, Test-OfficeC2RState, and Invoke-OfficeScrubC2R—along with structured output types and a comprehensive test suite. Review feedback identifies a potential deadlock in the command runner when handling process streams, a risk of enumeration failure during recursive directory cleanup due to permission issues, and redundant logic in the WhatIf parameter handling.

Comment thread src/OfficeScrubC2R.Core/CleanupExecutor.cs Outdated
Comment thread src/OfficeScrubC2R.Core/CommandRunner.cs
Comment thread src/OfficeScrubC2R.PowerShell/InvokeOfficeScrubC2RCommand.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 162ada3954

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/OfficeScrubC2R.Core/CleanupExecutor.cs Outdated
Comment thread src/OfficeScrubC2R.Core/CommandRunner.cs
Comment thread src/OfficeScrubC2R.PowerShell/InvokeOfficeScrubC2RCommand.cs Outdated
@Calvindd2f Calvindd2f added bug Something isn't working codex labels Apr 16, 2026
@Calvindd2f
Calvindd2f merged commit 517ad78 into master Apr 16, 2026
2 checks passed
@Calvindd2f
Calvindd2f deleted the codex/hardened-binary-baseline branch April 16, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error: Cannot bind argument to parameter 'Path' because it is an empty string.

1 participant