Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,57 @@ To install any optional dependencies, such as development dependencies, use:
```bash
pip install -e .[dev]
```

## Keywords

A **keyword** is a typed named value served over libby, with a uniform payload convention:

- `{}` → show (return current value)
- `{"value": V}` → modify (apply, then return it)

Types: `BoolKeyword`, `IntKeyword`, `FloatKeyword`, `StringKeyword`,
`TriggerKeyword`. Access mode is inferred — pass a `getter` for
read-only, a `setter` for write-only, both for read-write. Optional
extras: `units`, `description`, `nullable`, `validator`.

Each `Libby` peer carries a `keyword_registry` with typed builder
methods. Build keywords by calling `lib.keyword_registry.<type>(...)`,
then flush them to the peer with `register_keywords`:

```python
from libby import Libby

libby = Libby.rabbitmq(self_id="my-peer", rabbitmq_url="amqp://localhost")

state = {"position": 0.0}
libby.keyword_registry.bool("online", getter=lambda: True)
libby.keyword_registry.float("position",
getter=lambda: state["position"],
setter=lambda v: state.update(position=v),
units="mm")
libby.keyword_registry.trigger("halt", action=lambda: print("halted"))

libby.register_keywords(libby.keyword_registry.drain())
```

You can also build keywords directly via `BoolKeyword(...)` /
`FloatKeyword(...)` etc. and pass a list to `register_keywords`. The
registry is a convenience layer over the same type classes.

Clients call the keyword by name:

```python
client = Libby.rabbitmq(self_id="client", rabbitmq_url="amqp://localhost")

client.rpc("my-peer", "position", {}) # show
client.rpc("my-peer", "position", {"value": 12.5}) # modify
client.rpc("my-peer", "halt", {"value": 1}) # fire
```

Two meta-services are auto-registered on every peer that uses the
keyword registry:

- `keys.list` — payload `{"pattern": "..."}` (default `"%"`) → names,
sorted. `%` wildcards within a single name.
- `keys.describe` — payload `{"name": "..."}` → flat metadata dict.
Exact lookup; no wildcards.
26 changes: 24 additions & 2 deletions libby/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,29 @@
from bamboo.protocol import Protocol
from bamboo.builder import MessageBuilder
from bamboo.keys import KeyRegistry
from .zmq_transport import ZmqTransport
from .libby import Libby
from .keyword import (
Keyword,
BoolKeyword,
IntKeyword,
FloatKeyword,
StringKeyword,
TriggerKeyword,
match_pattern,
)
from .keyword_registry import KeywordRegistry

__all__ = ["Libby", "ZmqTransport", "Protocol", "MessageBuilder", "KeyRegistry"]
__all__ = [
"Libby",
"Protocol",
"MessageBuilder",
"KeyRegistry",
"Keyword",
"BoolKeyword",
"IntKeyword",
"FloatKeyword",
"StringKeyword",
"TriggerKeyword",
"KeywordRegistry",
"match_pattern",
]
210 changes: 210 additions & 0 deletions libby/keyword.py
Copy link
Copy Markdown
Collaborator

@prkrtg prkrtg Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it

        FloatKeyword(f"positionvalue{s}",
                     getter=lambda: self.controller.get_pos(self.device_key, self.axis),
                     setter=self._set_position,
                     validator=self._check_soft_limits,
                     units=self.units,
                     description="Stage position in engineering units."),

What about making a builder object?

from libby import (
    FloatKeyword
)

class KeywordBuilder:
    def __init__(self, daemon):
        self._daemon = daemon
        self._keywords = []

    def _add(self, kw):
        self._keywords.append(kw)
        return kw

    def float(self, name, *, get=None, set=None, units=None,
              description="", nullable=False, validator=None):
        return self._add(
            FloatKeyword(
                name,
                getter=get,
                setter=set,
                units=units,
                description=description,
                nullable=nullable,
                validator=validator,
            )
        )

Then in Hispec

class HispecDaemon:
    def __init__(self):
        self.keywords = KeywordBuilder(self)

def on_start(self, _libby):
    self.keywords.float(
        "position",
        get=lambda: self.controller.get_pos(...),
        set=self._set_position,
        units="mm",
        description="Stage position",
    )

Original file line number Diff line number Diff line change
@@ -0,0 +1,210 @@
"""Keyword classes for Libby."""
from __future__ import annotations

import re
from typing import Any, Callable, Iterable, List, Optional

Getter = Callable[[], Any]
Setter = Callable[[Any], None]
Validator = Callable[[Any], Optional[str]]
Action = Callable[[], None]


def match_pattern(pattern: str, names: Iterable[str]) -> List[str]:
"""Return names matching ``pattern``, sorted. ``%`` is a wildcard;
it matches any run of characters excluding ``.``."""
parts = pattern.split("%")
rx = re.compile("^" + "[^.]*".join(re.escape(p) for p in parts) + "$")
return sorted(n for n in names if rx.match(n))


class Keyword:
"""Named value exposed as a libby service."""

type_name: str = "any"

def __init__(
self,
name: str,
*,
getter: Optional[Getter] = None,
setter: Optional[Setter] = None,
units: Optional[str] = None,
description: str = "",
nullable: bool = False,
validator: Optional[Validator] = None,
) -> None:
if getter is None and setter is None:
raise ValueError(
f"keyword '{name}' must supply at least one of getter/setter"
)
self.name = name
self._getter = getter
self._setter = setter
self.units = units
self.description = description
self.nullable = nullable
self._validator = validator

@property
def readonly(self) -> bool:
return self._setter is None

@property
def writeonly(self) -> bool:
return self._getter is None

def _type_check(self, v: Any) -> Any:
"""Type-check or cast ``v``. Override per subclass."""
return v

def _response(self, value: Any) -> dict:
out: dict[str, Any] = {"ok": True, "value": value}
if self.units is not None:
out["units"] = self.units
return out

def describe(self) -> dict:
out: dict[str, Any] = {
"name": self.name,
"type": self.type_name,
"readonly": self.readonly,
"writeonly": self.writeonly,
"nullable": self.nullable,
}
if self.units is not None:
out["units"] = self.units
if self.description:
out["description"] = self.description
return out

def handle(self, payload: dict) -> dict:
if "value" in payload:
return self._modify(payload["value"])
return self._show()

def _show(self) -> dict:
if self.writeonly:
return {"ok": False, "error": "keyword is write-only"}
try:
value = self._getter() # type: ignore[misc]
except Exception as e:
return {"ok": False, "error": str(e)}
return self._response(value)

def _modify(self, raw: Any) -> dict:
if self.readonly:
return {"ok": False, "error": "keyword is read-only"}
if raw is None:
if not self.nullable:
return {"ok": False, "error": f"value must be {self.type_name}"}
value: Any = None
else:
try:
value = self._type_check(raw)
except (TypeError, ValueError) as e:
return {"ok": False, "error": str(e)}
if self._validator is not None:
verr = self._validator(value)
if verr:
return {"ok": False, "error": verr}
try:
self._setter(value) # type: ignore[misc]
except Exception as e:
return {"ok": False, "error": str(e)}
return self._response(value)


class BoolKeyword(Keyword):
"""Keyword whose value is a Python ``bool``."""

type_name = "bool"

def _type_check(self, v: Any) -> bool:
if not isinstance(v, bool):
raise TypeError("value must be a bool")
return v


class IntKeyword(Keyword):
"""Keyword whose value is a Python ``int``; ``bool`` is rejected."""

type_name = "int"

def _type_check(self, v: Any) -> int:
# bool is a subclass of int in Python; reject explicitly
if isinstance(v, bool) or not isinstance(v, int):
raise TypeError("value must be an int")
return v


class FloatKeyword(Keyword):
"""Keyword whose value is a Python ``float``; accepts ``int``, rejects ``bool``."""

type_name = "float"

def _type_check(self, v: Any) -> float:
if isinstance(v, bool) or not isinstance(v, (int, float)):
raise TypeError("value must be a number")
return float(v)


class StringKeyword(Keyword):
"""Keyword whose value is a Python ``str``."""

type_name = "string"

def _type_check(self, v: Any) -> str:
if not isinstance(v, str):
raise TypeError("value must be a string")
return v


class TriggerKeyword(Keyword):
"""Write-only action keyword. Any modify fires ``action``; show returns ``false``."""

type_name = "trigger"

def __init__(
self,
name: str,
*,
action: Action,
description: str = "",
) -> None:
self.name = name
self._action = action
self._getter = None
self._setter = None
self.units = None
self.description = description
self.nullable = False
self._validator = None

@property
def readonly(self) -> bool:
return False

@property
def writeonly(self) -> bool:
return True

def handle(self, payload: dict) -> dict:
if "value" not in payload:
return {"ok": True, "value": False}
try:
self._action()
except Exception as e:
return {"ok": False, "error": str(e)}
return {"ok": True, "value": True}


__all__ = [
"Keyword",
"BoolKeyword",
"IntKeyword",
"FloatKeyword",
"StringKeyword",
"TriggerKeyword",
"match_pattern",
]
Loading