Skip to content

Fix more of the 100 Great Theorems - #22

Open
dnezam wants to merge 9 commits into
masterfrom
fix-top100
Open

dnezam wants to merge 9 commits into
masterfrom
fix-top100

Conversation

@dnezam

@dnezam dnezam commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The first example in sos.ml now works thanks to some upstream fixes.

- Lack of let-polymorphism
- More interesting: candle/compute.ml is loaded at the very end, and its
  overloads led to RAMSEY_LEMMA3's proof failing. Fixed it by adding an overload
  call that is like HOL4's inferior overloads.
- Some float parsing issues I've worked around with using float_of_int
- Implemented frexp
  - It would probably be better if num_of_float was part of the bignum library
- Implemented float_of_num
  - Since there does not seem to be a rat -> double function, I hacked it in by
    converting the denominator and numerator to floats and dividing there;
    this is probably terrible in terms of precision and would probably better
    off done properly in the bignum library
Still, first example does not work.
@dnezam

dnezam commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

Waiting on the resolution of CakeML/cakeml#1581.
Also, some theorems seem to timeout - maybe the Python script just needs to have bigger timeouts.

- Increase default timeout (needed for some of the 100 Great Theorems)
- Correct timeout description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant